Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve ui of out-of-stock products on the cart page #443

Merged
merged 1 commit into from
Oct 29, 2020

Conversation

SGrueber
Copy link
Collaborator

@SGrueber SGrueber commented Oct 27, 2020

PR Type

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] CI-related changes
[ ] Documentation content changes
[ ] Application / infrastructure changes
[ ] Other:

What Is the Current Behavior?

If the user adds a product to cart and the product gets undeliverable, an error section is displayed.
The messages and the item description in the table are center-aligned.
The product name in the table is bold.

Issue Number: Closes #438

What Is the New Behavior?

The messages and the item description in table are left-aligned.
The product name in the table is not bold.

Does this PR Introduce a Breaking Change?

[ ] Yes
[x] No

Other Information

@SGrueber SGrueber self-assigned this Oct 27, 2020
@SGrueber SGrueber added this to the 0.25 milestone Oct 27, 2020
Copy link

@iwiederhold iwiederhold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bug was fixed. Fine.
The distance between message and basket image is too large now. The user can't see the "CONTINUE SHOPPING" button.
Improvment:
.empty-cart .empty-cart-icon {
padding: 55px 0 30px;
}

padding 105px --> 55px

@iwiederhold iwiederhold self-requested a review October 28, 2020 09:21
@SGrueber
Copy link
Collaborator Author

SGrueber commented Oct 28, 2020

It depends on the user's screen size whether he can see the continue shopping button.
Nevertheless I changed the empty-cart-icon top padding from 105 to 60 ( 4 * spaceDefault)

@SGrueber SGrueber force-pushed the bugfix/out_of_stock_products_in_cart branch from 208cb53 to 45e83be Compare October 28, 2020 12:56
@SGrueber SGrueber merged commit 5488707 into develop Oct 29, 2020
@SGrueber SGrueber deleted the bugfix/out_of_stock_products_in_cart branch October 29, 2020 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False styling and missing product names in cart adjustment messages on empty page
4 participants