Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On operations that sync IRIS with git repo, diagnostic output from sync is lost #426

Closed
isc-tleavitt opened this issue Jul 12, 2024 · 0 comments · Fixed by #435
Closed
Assignees
Labels
bug Something isn't working

Comments

@isc-tleavitt
Copy link
Collaborator

Suppose syncing with IRIS (generally via SourceControl.Git.PullEventHandler:ForModifications or ForInternalNames) fails because of a compilation error - or succeeds with a bunch of stuff compiled. We have now way of knowing, because the output is thrown away, and any errors that occur are thrown as exceptions.

In SourceControl.Git.Utils:RunGitCommandWithInput we should allow the sync operation to fail. Output from the sync operation should be captured using the XDEV string buffer, same as is currently done in WebUIDriver (which will pose an issue - we'll need to remove that due to limitations with the string buffer and push everything into RunGitCommandWithInput). This output should be appended to the output stream with output from git, and if any errors occur they should be written to the err stream with error output from git. This should "just work" in the Web UI - errors will be shown as such.

Current bad behavior in the web ui is that after such a command errors, there's an output message that's totally useless saying that the webui server is not running - this is a holdout from the original Git WebUI open source project and doesn't make any sense at all because of course IRIS is running.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants