You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Suppose syncing with IRIS (generally via SourceControl.Git.PullEventHandler:ForModifications or ForInternalNames) fails because of a compilation error - or succeeds with a bunch of stuff compiled. We have now way of knowing, because the output is thrown away, and any errors that occur are thrown as exceptions.
In SourceControl.Git.Utils:RunGitCommandWithInput we should allow the sync operation to fail. Output from the sync operation should be captured using the XDEV string buffer, same as is currently done in WebUIDriver (which will pose an issue - we'll need to remove that due to limitations with the string buffer and push everything into RunGitCommandWithInput). This output should be appended to the output stream with output from git, and if any errors occur they should be written to the err stream with error output from git. This should "just work" in the Web UI - errors will be shown as such.
Current bad behavior in the web ui is that after such a command errors, there's an output message that's totally useless saying that the webui server is not running - this is a holdout from the original Git WebUI open source project and doesn't make any sense at all because of course IRIS is running.
The text was updated successfully, but these errors were encountered:
Suppose syncing with IRIS (generally via SourceControl.Git.PullEventHandler:ForModifications or ForInternalNames) fails because of a compilation error - or succeeds with a bunch of stuff compiled. We have now way of knowing, because the output is thrown away, and any errors that occur are thrown as exceptions.
In SourceControl.Git.Utils:RunGitCommandWithInput we should allow the sync operation to fail. Output from the sync operation should be captured using the XDEV string buffer, same as is currently done in WebUIDriver (which will pose an issue - we'll need to remove that due to limitations with the string buffer and push everything into RunGitCommandWithInput). This output should be appended to the output stream with output from git, and if any errors occur they should be written to the err stream with error output from git. This should "just work" in the Web UI - errors will be shown as such.
Current bad behavior in the web ui is that after such a command errors, there's an output message that's totally useless saying that the webui server is not running - this is a holdout from the original Git WebUI open source project and doesn't make any sense at all because of course IRIS is running.
The text was updated successfully, but these errors were encountered: