-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keep iris sync output #435
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some nitpicks, removing a comment and suggesting a clearer description in changelog
@@ -4,8 +4,6 @@ Class SourceControl.Git.WebUIDriver | |||
ClassMethod HandleRequest(pagePath As %String, InternalName As %String = "", Output handled As %Boolean = 0, Output %data As %Stream.Object) | |||
{ | |||
// Make sure we capture any stray output |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's remove this comment which is no longer accurate
CHANGELOG.md
Outdated
@@ -17,6 +17,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
- WebUI workspace view now works properly for filenames with spaces (#423) | |||
- Fixed error popups in interop editors in Studio on 2024.1 (#417) | |||
- Reintroduced amend (#425) | |||
- IRIS sync output is no longer lost (#426) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- IRIS sync output is no longer lost (#426) | |
- Git operations that import items into IRIS now report output from compilation (#426) |
Fixes #426