fix: read topic from message receipt

intility · Sep 27, 2024 · ebce1f0 · ebce1f0
1 parent 1e9e663
commit ebce1f0
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 3 deletions.
diff --git a/Changelog.md b/Changelog.md
@@ -1,6 +1,13 @@
 # Changelog
 
-## 0.1.0 - Initial release
+## v0.1.1 - Patch
+
+_Released unreleased_
+
+- Emitting `off_broadway_emqtt.receive_message.ack` reads message topic from message receipt instead of from the message body.
+ This ensures that topic is included in telemetry events even if the message has been altered during dispatch.
+
+## v0.1.0 - Initial release
 
 _Released 2024-09-24_
 

diff --git a/lib/off_broadway/emqqt/message_handler.ex b/lib/off_broadway/emqqt/message_handler.ex
@@ -84,10 +84,12 @@ defmodule OffBroadway.EMQTT.MessageHandler do
   end
 
   def ack_message(message, _ack_options) do
+    receipt = extract_message_receipt(message)
+
     :telemetry.execute(
       [:off_broadway_emqtt, :receive_message, :ack],
       %{time: System.system_time(), count: 1},
-      %{topic: message.data.topic, receipt: extract_message_receipt(message)}
+      %{topic: receipt.topic, receipt: receipt}
     )
   end
 

diff --git a/mix.exs b/mix.exs
@@ -1,7 +1,7 @@
 defmodule OffBroadway.EMQTT.MixProject do
   use Mix.Project
 
-  @version "0.1.0"
+  @version "0.1.1"
   @description "An MQTT connector based on emqtt for Broadway."
   @source_url "https://github.com/Intility/off_broadway_emqtt"