doi: handle UI for optional DOI feature #2933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
anikachurilova
commented
Dec 5, 2024
anikachurilova
commented
- closes DOI: make default option selection configurable CERNDocumentServer/cds-rdm#163
zzacharo
reviewed
Dec 13, 2024
invenio_app_rdm/ext.py
Outdated
| @@ -33,6 +33,17 @@ def finalize_app(app): | |||
|
|
|||
| def init_config(app): | |||
| """Initialize configuration.""" | |||
| record_doi_required = app.config["RDM_PERSISTENT_IDENTIFIERS"]["doi"]["required"] | |||
There was a problem hiding this comment.
must not assume that doi is configured
zzacharo
reviewed
Dec 13, 2024
invenio_app_rdm/ext.py
Outdated
| @@ -33,6 +33,17 @@ def finalize_app(app): | |||
|
|
|||
| def init_config(app): | |||
| """Initialize configuration.""" | |||
| record_doi_required = app.config["RDM_PERSISTENT_IDENTIFIERS"]["doi"]["required"] | |||
| parent_doi_required = app.config["RDM_PARENT_PERSISTENT_IDENTIFIERS"]["doi"][ | |||
There was a problem hiding this comment.
must not assume that doi is configured
zzacharo
force-pushed
the
optional-doi-feature
branch
6 times, most recently
from
baeddd5 to
f3c27a8
Compare
zzacharo
force-pushed
the
optional-doi-feature
branch
from
f3c27a8 to
1456436
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.