fix(analytics): added a validation for length in analytics().logEvent…

…(name, params) (#4522) * Needs to check the length for name of analytics().logEvent(name, params): 1-40 alphanumeric
invertase · Nov 9, 2020 · 107b07d · 107b07d · vercel · Nov 9, 2020
1 parent f23de50
commit 107b07d
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/packages/analytics/__tests__/analytics.test.ts b/packages/analytics/__tests__/analytics.test.ts
@@ -160,7 +160,7 @@ describe('Analytics', () => {
 
     it('errors if name not alphanumeric', () => {
       expect(() => firebase.analytics().logEvent('!@£$%^&*')).toThrowError(
-        "firebase.analytics().logEvent(*) 'name' invalid event name '!@£$%^&*'. Names should contain 1 to 32 alphanumeric characters or underscores.",
+        "firebase.analytics().logEvent(*) 'name' invalid event name '!@£$%^&*'. Names should contain 1 to 40 alphanumeric characters or underscores.",
       );
     });
 

diff --git a/packages/analytics/lib/index.js b/packages/analytics/lib/index.js
@@ -76,9 +76,9 @@ class FirebaseAnalyticsModule extends FirebaseModule {
     }
 
     // name format validation
-    if (!isAlphaNumericUnderscore(name)) {
+    if (!isAlphaNumericUnderscore(name) || name.length > 40) {
       throw new Error(
-        `firebase.analytics().logEvent(*) 'name' invalid event name '${name}'. Names should contain 1 to 32 alphanumeric characters or underscores.`,
+        `firebase.analytics().logEvent(*) 'name' invalid event name '${name}'. Names should contain 1 to 40 alphanumeric characters or underscores.`,
       );
     }