-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(analytics): added a validation for length in analytics().logEvent(name, params) #4522
Conversation
…ms): 1-40 alphanumeric
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/invertase/react-native-firebase/plg0kmcxi [Deployment for 71345a8 failed] |
Looks like the test needs an update as well:
at packages/analytics/tests/analytics.test.ts:162:41 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good - just the CLA sign and the test update
…ms): 1-40 alphanumeric
Codecov Report
@@ Coverage Diff @@
## master #4522 +/- ##
=========================================
Coverage ? 41.92%
=========================================
Files ? 35
Lines ? 1119
Branches ? 278
=========================================
Hits ? 469
Misses ? 489
Partials ? 161 |
I am not sure why Vercel has failed. |
I'm not sure why Vercel is failing either 😅 - obviously has nothing to do with this PR though, I can merge without it passing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will pass now (or should...) I believe we're just missing the CLA now to merge
Thank you, Mike. |
Still missing the CLA signature though 🤔 @railsjack |
What should I do to pass it? |
@railsjack - follow the details link, should be https://cla-assistant.io/invertase/react-native-firebase?pullRequest=4522 - and sign the request with the same github userid / email used to make the PR |
Done. |
Fantastic - thanks for submitting this in the first place and sticking with it through all the administrivia bits :-) |
Description
I added a validation to check the length for
name
ofanalytics().logEvent(name, params)
: 1-40 alphanumericRelated issues
Fixes #4496
Release Summary
Checklist
Android
iOS
e2e
tests added or updated inpackages/\*\*/e2e
jest
tests added or updated inpackages/\*\*/__tests__
Test Plan
Think
react-native-firebase
is great? Please consider supporting the project with any of the below:React Native Firebase
andInvertase
on Twitter