fix(android, timezones): timezone offset already millis, do not adjust it

[mikehardy]

Description

Timezone.getOffset() provides result in milliseconds, but was being adjusted as if it were in seconds

Related issues

Fixes #4053 with issue noticed and fix provided by @AidanHost

Release Summary

fix(android, timezones): timezone offset already in millis, do not adjust it

Checklist

• I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • Yes
• My change supports the following platforms;
  • Android
  • iOS
• My change includes tests;
  • e2e tests added or updated in packages/\*\*/e2e
  • jest tests added or updated in packages/\*\*/__tests__
• I have updated TypeScript types that are affected by my change.
• This is a breaking change;
  • Yes
  • No

Test Plan

I am literally making this change directly in the github web UI and relying on the automated test to handle it.

The documentation linked appears very clear cut and the change is so small so that seems reasonably unreasonable

---

Think react-native-firebase is great? Please consider supporting the project with any of the below:

• 👉 Star this repo on GitHub ⭐️
• 👉 Follow React Native Firebase and Invertase on Twitter

[Salakar]

LGTM!

[mikehardy]

@Salakar CI flaked again but I re-ran it and it passed, but needs 2 reviews from not-me :)

[Salakar]

Lowered it to 1 review :)

[mikehardy]

I do so love hitting merge buttons 😄 🚀

tally-ho

[AidanHost]

Hi, so I checked the commit, but it's still not 100%. timestamp is in seconds, so it should be converted to millis.

something like this:

long millisTimestamp = timestamp * 1000;
Date date = new Date(millisTimestamp + calendar.getTimeZone().getOffset(millisTimestamp));

@mikehardy please see above

[mikehardy]

@AidanHost thank you for reviewing it! As the interested party, you can just use the Github web UI and hit the edit pencil on the file then post a PR with the change? I can do it if not - let me know - but that's all I'm doing (poorly apparently, sorry!)

[AidanHost]

@mikehardy thanks, that's where the edit button is. I couldn't find it before.

here is a PR for this issue: #4057