Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): timezone offset issue in util #4057

Merged
merged 1 commit into from
Aug 6, 2020
Merged

fix(core): timezone offset issue in util #4057

merged 1 commit into from
Aug 6, 2020

Conversation

AidanHost
Copy link
Contributor

@AidanHost AidanHost commented Aug 6, 2020

Description

Correcting the timezone offset and timestamp conversion calculation

Related issues

Follows on from #4055

Release Summary

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan


Think react-native-firebase is great? Please consider supporting the project with any of the below:

@CLAassistant
Copy link

CLAassistant commented Aug 6, 2020

CLA assistant check
All committers have signed the CLA.

@Salakar Salakar changed the title Update SharedUtils.java fix(core): timezone offset issue in util Aug 6, 2020
Copy link
Member

@Salakar Salakar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@AidanHost
Copy link
Contributor Author

I see we're not the only team that gets E2E timeouts 😄 . I don't see a way to re-run the checks, maybe only write permissions on the repo can re-run?

@mikehardy
Copy link
Collaborator


detox[4758] INFO:  [DetoxServer.js] server listening on localhost:49713...
detox[4758] ERROR: [exec.js/EXEC_FAIL, #23] ""/Users/runner/Library/Android/sdk/platform-tools/adb" -s emulator-5554 shell "ps | grep \"com\.invertase\.testing$\""" failed with code = 1, stdout and stderr:

detox[4758] ERROR: [exec.js/EXEC_FAIL, #23] 
detox[4758] ERROR: [exec.js/EXEC_FAIL, #23] 
  1) "before all" hook in "{root}"
detox[4758] INFO:  at e2e/init.js:53:11 
  ✨ Tests Complete ✨ 
detox[4758] ERROR: at internal/process/warning.js:25:20 
 (node:4758) UnhandledPromiseRejectionWarning: DetoxRuntimeError: Failed to run application on the device

Not enough to go on why, but it's somewhere in initial detox+app hookup, either APK install (Salakar theory) or something else unknown (my theory), with no data (yet) to validate either theory :)

I hit the re-run job button, 🤞

@mikehardy mikehardy merged commit cb6a1d4 into invertase:master Aug 6, 2020
@mikehardy
Copy link
Collaborator

Hopefully that one does the trick, thanks again @AidanHost

@AidanHost AidanHost deleted the patch-1 branch August 6, 2020 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants