fix(android, timezones): timezone offset already millis, do not adjust it #4055
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Timezone.getOffset() provides result in milliseconds, but was being adjusted as if it were in seconds
Related issues
Fixes #4053 with issue noticed and fix provided by @AidanHost
Release Summary
fix(android, timezones): timezone offset already in millis, do not adjust it
Checklist
Android
iOS
e2e
tests added or updated inpackages/\*\*/e2e
jest
tests added or updated inpackages/\*\*/__tests__
Test Plan
I am literally making this change directly in the github web UI and relying on the automated test to handle it.
The documentation linked appears very clear cut and the change is so small so that seems reasonably unreasonable
Think
react-native-firebase
is great? Please consider supporting the project with any of the below:React Native Firebase
andInvertase
on Twitter