-
Notifications
You must be signed in to change notification settings - Fork 2.3k
test(firestore): simplify firestore tests #4133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/invertase/react-native-firebase/9kfgp6hkb |
|
This looks good in general but is failing in CI: |
Codecov Report
@@ Coverage Diff @@
## master #4133 +/- ##
==========================================
- Coverage 67.10% 67.05% -0.05%
==========================================
Files 114 114
Lines 3820 3820
Branches 278 278
==========================================
- Hits 2563 2561 -2
- Misses 1148 1150 +2
Partials 109 109 |
|
|
||
| PODFILE CHECKSUM: 51062414d4f230ae385561d26f3c88e6c8a3ce28 | ||
|
|
||
| COCOAPODS: 1.10.0.beta.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not terribly relevant, but cocoapods has been stuck on 1.10.0-rc.1 for 29 days now, thought for sure it would be out. Anyway, this change doesn't really matter one way or the other and is not incorrect, just a comment
mikehardy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great and I suppose sets us up to more easily implement the new firestore operators they just added (there's always something to do... 😅 ) - thanks, I'll shepherd it through CI and get it merged
* test(firestore): clean up rules * docs(firestore): update e2e contributing docs * format: prettier e2e files * test: ios updates * testing ci ios tests * ci ios test * ci ios testing * revert project.pbxproj * test(firestore): fix broken tests * test(firestore): rm todo Co-authored-by: Mike Diarmid <mike.diarmid@gmail.com>
* test(firestore): clean up rules * docs(firestore): update e2e contributing docs * format: prettier e2e files * test: ios updates * testing ci ios tests * ci ios test * ci ios testing * revert project.pbxproj * test(firestore): fix broken tests * test(firestore): rm todo Co-authored-by: Mike Diarmid <mike.diarmid@gmail.com>
Description
Cleaned up rules so that only a single collection (
firestore) & a single collection group (collectionGroup) is used for tests.Related issues
As per this comment
Checklist
AndroidiOSe2etests added or updated inpackages/\*\*/e2ejesttests added or updated inpackages/\*\*/__tests__Think
react-native-firebaseis great? Please consider supporting the project with any of the below:React Native FirebaseandInvertaseon Twitter