-
Notifications
You must be signed in to change notification settings - Fork 2.3k
feat(firestore): query operators: 'not-in' & '!=' #4474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/invertase/react-native-firebase/jcw62dn2r |
Codecov Report
@@ Coverage Diff @@
## master #4474 +/- ##
=======================================
Coverage 41.92% 41.92%
=======================================
Files 35 35
Lines 1119 1119
Branches 278 278
=======================================
Hits 469 469
Misses 489 489
Partials 161 161 |
mikehardy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A whitespace nit but this looks great
|
One lint thing about whitespace too apparently? |
|
Just failing yarn install on CI E2E (seriously? yarn install is going to flake, c'mon...). I'll herd it through, I'm excited to see this go in |
|
Success! And everything passed :-) |
* feat(firestore): query operators: 'not-in' & '!=' * chore(firestore): update filters * test(firestore): not-in, != e2e tests * chore(ios): pods version updates * format: code format * chore(firestore): spelling & grammar * chore(firestore): PR feedback
Description
Feature update for Firestore; where query operators:
Checklist
AndroidiOSe2etests added or updated inpackages/\*\*/e2ejesttests added or updated inpackages/\*\*/__tests__Test Plan
Think
react-native-firebaseis great? Please consider supporting the project with any of the below:React Native FirebaseandInvertaseon Twitter