Skip to content

Conversation

@russellwheatley
Copy link
Member

Description

Feature update for Firestore; where query operators:

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan


Think react-native-firebase is great? Please consider supporting the project with any of the below:

@vercel
Copy link

vercel bot commented Oct 30, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/invertase/react-native-firebase/jcw62dn2r
✅ Preview: https://react-native-fireb-git-russell-firestore-query-not-in-no-311e55.invertase.vercel.app

@codecov
Copy link

codecov bot commented Oct 30, 2020

Codecov Report

Merging #4474 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4474   +/-   ##
=======================================
  Coverage   41.92%   41.92%           
=======================================
  Files          35       35           
  Lines        1119     1119           
  Branches      278      278           
=======================================
  Hits          469      469           
  Misses        489      489           
  Partials      161      161           

mikehardy
mikehardy previously approved these changes Oct 30, 2020
Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A whitespace nit but this looks great

@mikehardy mikehardy added Workflow: Pending Merge Waiting on CI or similar Workflow: Waiting for User Response Blocked waiting for user response. labels Oct 30, 2020
@mikehardy
Copy link
Collaborator

One lint thing about whitespace too apparently?

@mikehardy
Copy link
Collaborator

Just failing yarn install on CI E2E (seriously? yarn install is going to flake, c'mon...). I'll herd it through, I'm excited to see this go in

@mikehardy mikehardy removed the Workflow: Pending Merge Waiting on CI or similar label Oct 30, 2020
@mikehardy
Copy link
Collaborator

Success!
Locally I temporarily disabled the auth package in mocha.opts so I could get past it, and I ignored the firestore emulator per note here: #4133 (comment)

And everything passed :-)

@mikehardy mikehardy merged commit 9e68faf into master Oct 30, 2020
@mikehardy mikehardy deleted the @russell/firestore-query-not-in-not-equal branch October 30, 2020 20:28
androidIsForVivek pushed a commit to androidIsForVivek/react-native-firebase that referenced this pull request Aug 9, 2021
* feat(firestore): query operators: 'not-in' & '!='
* chore(firestore): update filters
* test(firestore): not-in, != e2e tests
* chore(ios): pods version updates
* format: code format
* chore(firestore): spelling & grammar
* chore(firestore): PR feedback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants