Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct path to 'Info.plist' in ios build script input #5677

Merged
merged 1 commit into from
Sep 2, 2021
Merged

fix: correct path to 'Info.plist' in ios build script input #5677

merged 1 commit into from
Sep 2, 2021

Conversation

smikheiev
Copy link
Contributor

Description

The issue was discussed a little here. I've been using a patch with this change for a while already and haven't seen this issue so far.

The path used in the script is _TARGET_PLIST="${BUILT_PRODUCTS_DIR}/${INFOPLIST_PATH}", but the path specified as "input files" was $(SRCROOT)/$(BUILT_PRODUCTS_DIR)/$(INFOPLIST_PATH). This caused that sometimes values from firebase.json were not taken into account on iOS, because build step "Processing Info.plist" could be executed after "[RNFB] Core Configuration" and it could overwrite the Info.plist file.

Related issues

Release Summary

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan


Think react-native-firebase is great? Please consider supporting the project with any of the below:

@CLAassistant
Copy link

CLAassistant commented Sep 2, 2021

CLA assistant check
All committers have signed the CLA.

@vercel
Copy link

vercel bot commented Sep 2, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

react-native-firebase – ./

🔍 Inspect: https://vercel.com/invertase/react-native-firebase/3r5DkwbaQFqCA7HABbrgFqGVbJky
✅ Preview: https://react-native-firebase-git-fork-smikheiev-patch-1-invertase.vercel.app

react-native-firebase-next – ./website_modular

🔍 Inspect: https://vercel.com/invertase/react-native-firebase-next/9Vcy7ncH63bZkvMstYNYqGP5Jqvw
✅ Preview: In Progress

[Deployment for cdd8489 canceled]

The path used in the script is `_TARGET_PLIST="${BUILT_PRODUCTS_DIR}/${INFOPLIST_PATH}"`, but the path specified as "input files" was `$(SRCROOT)/$(BUILT_PRODUCTS_DIR)/$(INFOPLIST_PATH)`. This caused that sometimes values from `firebase.json` were not taken into account on iOS, because build step "Processing Info.plist" could be executed after "[RNFB] Core Configuration" and it could overwrite the `Info.plist` file.
Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is correct, thanks!

@mikehardy mikehardy added the Workflow: Pending Merge Waiting on CI or similar label Sep 2, 2021
@codecov
Copy link

codecov bot commented Sep 2, 2021

Codecov Report

Merging #5677 (c911cce) into master (32ddef7) will decrease coverage by 19.45%.
The diff coverage is n/a.

❗ Current head c911cce differs from pull request most recent head cdd8489. Consider uploading reports for the commit cdd8489 to get more accurate results

@@              Coverage Diff              @@
##             master    #5677       +/-   ##
=============================================
- Coverage     73.08%   53.64%   -19.44%     
- Complexity        0      632      +632     
=============================================
  Files           109      208       +99     
  Lines          4487    10087     +5600     
  Branches        957     1544      +587     
=============================================
+ Hits           3279     5410     +2131     
- Misses         1129     4393     +3264     
- Partials         79      284      +205     

@mikehardy mikehardy removed the Workflow: Pending Merge Waiting on CI or similar label Sep 2, 2021
@mikehardy mikehardy merged commit ea6920c into invertase:master Sep 2, 2021
@smikheiev smikheiev deleted the patch-1 branch September 7, 2021 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants