-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: correct path to 'Info.plist' in ios build script input #5677
Conversation
This pull request is being automatically deployed with Vercel (learn more). react-native-firebase – ./🔍 Inspect: https://vercel.com/invertase/react-native-firebase/3r5DkwbaQFqCA7HABbrgFqGVbJky react-native-firebase-next – ./website_modular🔍 Inspect: https://vercel.com/invertase/react-native-firebase-next/9Vcy7ncH63bZkvMstYNYqGP5Jqvw [Deployment for cdd8489 canceled] |
The path used in the script is `_TARGET_PLIST="${BUILT_PRODUCTS_DIR}/${INFOPLIST_PATH}"`, but the path specified as "input files" was `$(SRCROOT)/$(BUILT_PRODUCTS_DIR)/$(INFOPLIST_PATH)`. This caused that sometimes values from `firebase.json` were not taken into account on iOS, because build step "Processing Info.plist" could be executed after "[RNFB] Core Configuration" and it could overwrite the `Info.plist` file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is correct, thanks!
Codecov Report
@@ Coverage Diff @@
## master #5677 +/- ##
=============================================
- Coverage 73.08% 53.64% -19.44%
- Complexity 0 632 +632
=============================================
Files 109 208 +99
Lines 4487 10087 +5600
Branches 957 1544 +587
=============================================
+ Hits 3279 5410 +2131
- Misses 1129 4393 +3264
- Partials 79 284 +205 |
Description
The issue was discussed a little here. I've been using a patch with this change for a while already and haven't seen this issue so far.
The path used in the script is
_TARGET_PLIST="${BUILT_PRODUCTS_DIR}/${INFOPLIST_PATH}"
, but the path specified as "input files" was$(SRCROOT)/$(BUILT_PRODUCTS_DIR)/$(INFOPLIST_PATH)
. This caused that sometimes values fromfirebase.json
were not taken into account on iOS, because build step "Processing Info.plist" could be executed after "[RNFB] Core Configuration" and it could overwrite theInfo.plist
file.Related issues
Release Summary
Checklist
Android
iOS
e2e
tests added or updated inpackages/\*\*/e2e
jest
tests added or updated inpackages/\*\*/__tests__
Test Plan
Think
react-native-firebase
is great? Please consider supporting the project with any of the below:React Native Firebase
andInvertase
on Twitter