Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correct path to 'Info.plist' in ios build script input #5677

Merged
merged 1 commit into from
Sep 2, 2021
Merged

fix: correct path to 'Info.plist' in ios build script input #5677

merged 1 commit into from
Sep 2, 2021

Commits on Sep 2, 2021

  1. fix: correct path to 'Info.plist' in ios build script input #5677 

    The path used in the script is `_TARGET_PLIST="${BUILT_PRODUCTS_DIR}/${INFOPLIST_PATH}"`, but the path specified as "input files" was `$(SRCROOT)/$(BUILT_PRODUCTS_DIR)/$(INFOPLIST_PATH)`. This caused that sometimes values from `firebase.json` were not taken into account on iOS, because build step "Processing Info.plist" could be executed after "[RNFB] Core Configuration" and it could overwrite the `Info.plist` file.
    @smikheiev
    smikheiev committed Sep 2, 2021
    Configuration menu
    Copy the full SHA
    cdd8489 View commit details
    Browse the repository at this point in the history