Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app, ios-config): use fully-specified path for /usr/bin/head #5805

Merged
merged 1 commit into from
Oct 21, 2021

Conversation

mikehardy
Copy link
Collaborator

Description

It appears we have an expectation about what head binary will do,
and XAMMP at least bundles a different head which does not meet our
expectations.

This is a basic unix utility on all macs via the base install, so the full path to the
base install version should be a reasonable fix

Related issues

Fixes #5801

Release Summary

conventional commit

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan

CI should show it works


Think react-native-firebase is great? Please consider supporting the project with any of the below:

It appears we have an expectation about what `head` binary will do,
and XAMMP at least bundles a different `head` which does not meet our
expectations.

This is a basic unix utility on all macs via the base install, so the full path to the
base install version should be a reasonable fix

Fixes #5801
@vercel
Copy link

vercel bot commented Oct 21, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

react-native-firebase – ./

🔍 Inspect: https://vercel.com/invertase/react-native-firebase/Dpba5zHLTbTnLGBwvVwgwR2yN8HL
✅ Preview: https://react-native-firebase-git-mikehardy-full-path-f41b7b-invertase.vercel.app

react-native-firebase-next – ./website_modular

🔍 Inspect: https://vercel.com/invertase/react-native-firebase-next/CVR2vhB9ASeR4NvJCzVZxvPePJ6j
✅ Preview: Canceled

@mikehardy mikehardy added the Workflow: Pending Merge Waiting on CI or similar label Oct 21, 2021
@codecov
Copy link

codecov bot commented Oct 21, 2021

Codecov Report

Merging #5805 (4d2e33a) into master (6f435cf) will not change coverage.
The diff coverage is n/a.

❗ Current head 4d2e33a differs from pull request most recent head 87bff4a. Consider uploading reports for the commit 87bff4a to get more accurate results

@@            Coverage Diff            @@
##             master    #5805   +/-   ##
=========================================
  Coverage     53.14%   53.14%           
  Complexity      620      620           
=========================================
  Files           208      208           
  Lines         10071    10071           
  Branches       1542     1542           
=========================================
  Hits           5351     5351           
  Misses         4464     4464           
  Partials        256      256           

@mikehardy mikehardy merged commit 5baaf13 into master Oct 21, 2021
@mikehardy mikehardy deleted the @mikehardy/full-path-to-head-utility branch October 21, 2021 17:50
@mikehardy mikehardy removed the Workflow: Pending Merge Waiting on CI or similar label Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

iOS Command PhaseScriptExecution failed - Assumptions about 'head' utility on the execution PATH
1 participant