fix(ios): use fully-specified path to required head utility #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this removes any possible ambiguity on what utility we require for config, solving a problem where sometimes a utility that performs HTTP HEAD requests is found instead of the standard BSD file utility
mikehardy
added
the
workflow: pending merge
Codecov Report
@@ Coverage Diff @@
## main #280 +/- ##
=======================================
Coverage 33.51% 33.51%
=======================================
Files 33 33
Lines 797 797
Branches 198 198
=======================================
Hits 267 267
Misses 530 530 |
mikehardy
removed
the
workflow: pending merge
|
🎉 This PR is included in version 8.2.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This removes any possible ambiguity on what utility we require for config, solving a problem where sometimes a utility that performs HTTP HEAD requests is found instead of the standard BSD file utility
Related issues
Fixes #279
Related invertase/react-native-firebase#5805 / invertase/react-native-firebase#5801
Release Summary
Checklist
and followed the process outlined there for submitting PRs.
AndroidiOSe2etests added or updated in__tests__e2e__jesttests added or updated in__tests__Test Plan
Tested by original reporter, in successful use for approximately a year in react-native-firebase
Think
react-native-google-mobile-adsis great? Please consider supporting the project with any of the below:Invertaseon Twitter