-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Feature/flake8 #4237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/flake8 #4237
Conversation
lstein
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great. flake8 seems to have caught lots of problems. Better get this in before more conflicts accrue. I see a bunch already.
|
@lillekemiker I'm watching the conflicts build up. Are you planning to re-run |
So flake8 only finds the errors, I have to correct them myself, unfortunately. But I don't mind. |
eb0325c to
d1a152d
Compare
|
@lillekemiker Ah, right - those have merged and the path is clear for this PR :) |
|
@psychedelicious @lstein - This should be ready merge as soon as the tests clear (which they already have locally) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I'd like to get another set of eyes to glance over the changes before merging. Oh, Lincoln has already reviewed, nvm
What type of PR is this? (check all applicable)
Have you discussed this change with the InvokeAI team?
Have you updated all relevant documentation?
Description
As per my suggestions here https://github.com/invoke-ai/InvokeAI/discussions/3721
I am adding flake8 checks to GHA, to pre-commit hooks and also cleaning up flake8 issues.
Related Tickets & Documents
QA Instructions, Screenshots, Recordings
Added/updated tests?
have not been included
[optional] Are there any post deployment tasks we need to perform?