Feature/flake8

.github/workflows/style-checks.yml

@@ -1,6 +1,6 @@
 name: style checks
-# just formatting for now
-# TODO: add isort and flake8 later
+# just formatting and flake8 for now
+# TODO: add isort later
 
 on:
   pull_request:
@@ -20,8 +20,8 @@ jobs:
 
       - name: Install dependencies with pip
         run: |
-          pip install black
+          pip install black flake8 Flake8-pyproject
 
       # - run: isort --check-only .
       - run: black --check .
-      # - run: flake8
+      - run: flake8

.pre-commit-config.yaml

@@ -8,3 +8,10 @@ repos:
     language: system
     entry: black
     types: [python]
+
+  - id: flake8
+    name: flake8
+    stages: [commit]
+    language: system
+    entry: flake8
+    types: [python]

installer/lib/installer.py

@@ -407,7 +407,7 @@ def get_pip_from_venv(venv_path: Path) -> str:
     :rtype: str
     """
 
-    pip = "Scripts\pip.exe" if OS == "Windows" else "bin/pip"
+    pip = "Scripts\\pip.exe" if OS == "Windows" else "bin/pip"
     return str(venv_path.expanduser().resolve() / pip)
 
 

installer/lib/main.py

@@ -49,7 +49,7 @@
 
     try:
         inst.install(**args.__dict__)
-    except KeyboardInterrupt as exc:
+    except KeyboardInterrupt:
         print("\n")
         print("Ctrl-C pressed. Aborting.")
         print("Come back soon!")

installer/lib/messages.py

@@ -70,7 +70,7 @@ def confirm_install(dest: Path) -> bool:
         )
     else:
         print(f"InvokeAI will be installed in {dest}")
-        dest_confirmed = not Confirm.ask(f"Would you like to pick a different location?", default=False)
+        dest_confirmed = not Confirm.ask("Would you like to pick a different location?", default=False)
     console.line()
 
     return dest_confirmed
@@ -90,7 +90,7 @@ def dest_path(dest=None) -> Path:
         dest = Path(dest).expanduser().resolve()
     else:
         dest = Path.cwd().expanduser().resolve()
-    prev_dest = dest.expanduser().resolve()
+    prev_dest = init_path = dest
 
     dest_confirmed = confirm_install(dest)
 
@@ -109,9 +109,9 @@ def dest_path(dest=None) -> Path:
         )
 
         console.line()
-        print(f"[orange3]Please select the destination directory for the installation:[/] \[{browse_start}]: ")
+        console.print(f"[orange3]Please select the destination directory for the installation:[/] \\[{browse_start}]: ")
         selected = prompt(
-            f">>> ",
+            ">>> ",
             complete_in_thread=True,
             completer=path_completer,
             default=str(browse_start) + os.sep,
@@ -134,14 +134,14 @@ def dest_path(dest=None) -> Path:
     try:
         dest.mkdir(exist_ok=True, parents=True)
         return dest
-    except PermissionError as exc:
-        print(
+    except PermissionError:
+        console.print(
             f"Failed to create directory {dest} due to insufficient permissions",
             style=Style(color="red"),
             highlight=True,
         )
-    except OSError as exc:
-        console.print_exception(exc)
+    except OSError:
+        console.print_exception()
 
     if Confirm.ask("Would you like to try again?"):
         dest_path(init_path)

invokeai/app/api/dependencies.py

@@ -1,6 +1,5 @@
 # Copyright (c) 2022 Kyle Schouviller (https://github.com/kyle0654)
 
-from typing import Optional
 from logging import Logger
 from invokeai.app.services.board_image_record_storage import (
     SqliteBoardImageRecordStorage,
@@ -45,7 +44,7 @@ def check_internet() -> bool:
     try:
         urllib.request.urlopen(host, timeout=1)
         return True
-    except:
+    except Exception:
         return False
 
 

invokeai/app/api/routers/board_images.py

@@ -34,7 +34,7 @@ async def add_image_to_board(
             board_id=board_id, image_name=image_name
         )
         return result
-    except Exception as e:
+    except Exception:
         raise HTTPException(status_code=500, detail="Failed to add image to board")
 
 
@@ -53,7 +53,7 @@ async def remove_image_from_board(
     try:
         result = ApiDependencies.invoker.services.board_images.remove_image_from_board(image_name=image_name)
         return result
-    except Exception as e:
+    except Exception:
         raise HTTPException(status_code=500, detail="Failed to remove image from board")
 
 
@@ -79,10 +79,10 @@ async def add_images_to_board(
                     board_id=board_id, image_name=image_name
                 )
                 added_image_names.append(image_name)
-            except:
+            except Exception:
                 pass
         return AddImagesToBoardResult(board_id=board_id, added_image_names=added_image_names)
-    except Exception as e:
+    except Exception:
         raise HTTPException(status_code=500, detail="Failed to add images to board")
 
 
@@ -105,8 +105,8 @@ async def remove_images_from_board(
             try:
                 ApiDependencies.invoker.services.board_images.remove_image_from_board(image_name=image_name)
                 removed_image_names.append(image_name)
-            except:
+            except Exception:
                 pass
         return RemoveImagesFromBoardResult(removed_image_names=removed_image_names)
-    except Exception as e:
+    except Exception:
         raise HTTPException(status_code=500, detail="Failed to remove images from board")

invokeai/app/api/routers/boards.py

@@ -37,7 +37,7 @@ async def create_board(
     try:
         result = ApiDependencies.invoker.services.boards.create(board_name=board_name)
         return result
-    except Exception as e:
+    except Exception:
         raise HTTPException(status_code=500, detail="Failed to create board")
 
 
@@ -50,7 +50,7 @@ async def get_board(
     try:
         result = ApiDependencies.invoker.services.boards.get_dto(board_id=board_id)
         return result
-    except Exception as e:
+    except Exception:
         raise HTTPException(status_code=404, detail="Board not found")
 
 
@@ -73,7 +73,7 @@ async def update_board(
     try:
         result = ApiDependencies.invoker.services.boards.update(board_id=board_id, changes=changes)
         return result
-    except Exception as e:
+    except Exception:
         raise HTTPException(status_code=500, detail="Failed to update board")
 
 
@@ -105,7 +105,7 @@ async def delete_board(
                 deleted_board_images=deleted_board_images,
                 deleted_images=[],
             )
-    except Exception as e:
+    except Exception:
         raise HTTPException(status_code=500, detail="Failed to delete board")
 
 

invokeai/app/api/routers/images.py

@@ -55,7 +55,7 @@ async def upload_image(
         if crop_visible:
             bbox = pil_image.getbbox()
             pil_image = pil_image.crop(bbox)
-    except:
+    except Exception:
         # Error opening the image
         raise HTTPException(status_code=415, detail="Failed to read image")
 
@@ -73,7 +73,7 @@ async def upload_image(
         response.headers["Location"] = image_dto.image_url
 
         return image_dto
-    except Exception as e:
+    except Exception:
         raise HTTPException(status_code=500, detail="Failed to create image")
 
 
@@ -85,7 +85,7 @@ async def delete_image(
 
     try:
         ApiDependencies.invoker.services.images.delete(image_name)
-    except Exception as e:
+    except Exception:
         # TODO: Does this need any exception handling at all?
         pass
 
@@ -97,7 +97,7 @@ async def clear_intermediates() -> int:
     try:
         count_deleted = ApiDependencies.invoker.services.images.delete_intermediates()
         return count_deleted
-    except Exception as e:
+    except Exception:
         raise HTTPException(status_code=500, detail="Failed to clear intermediates")
         pass
 
@@ -115,7 +115,7 @@ async def update_image(
 
     try:
         return ApiDependencies.invoker.services.images.update(image_name, image_changes)
-    except Exception as e:
+    except Exception:
         raise HTTPException(status_code=400, detail="Failed to update image")
 
 
@@ -131,7 +131,7 @@ async def get_image_dto(
 
     try:
         return ApiDependencies.invoker.services.images.get_dto(image_name)
-    except Exception as e:
+    except Exception:
         raise HTTPException(status_code=404)
 
 
@@ -147,7 +147,7 @@ async def get_image_metadata(
 
     try:
         return ApiDependencies.invoker.services.images.get_metadata(image_name)
-    except Exception as e:
+    except Exception:
         raise HTTPException(status_code=404)
 
 
@@ -183,7 +183,7 @@ async def get_image_full(
         )
         response.headers["Cache-Control"] = f"max-age={IMAGE_MAX_AGE}"
         return response
-    except Exception as e:
+    except Exception:
         raise HTTPException(status_code=404)
 
 
@@ -212,7 +212,7 @@ async def get_image_thumbnail(
         response = FileResponse(path, media_type="image/webp", content_disposition_type="inline")
         response.headers["Cache-Control"] = f"max-age={IMAGE_MAX_AGE}"
         return response
-    except Exception as e:
+    except Exception:
         raise HTTPException(status_code=404)
 
 
@@ -234,7 +234,7 @@ async def get_image_urls(
             image_url=image_url,
             thumbnail_url=thumbnail_url,
         )
-    except Exception as e:
+    except Exception:
         raise HTTPException(status_code=404)
 
 
@@ -282,10 +282,10 @@ async def delete_images_from_list(
             try:
                 ApiDependencies.invoker.services.images.delete(image_name)
                 deleted_images.append(image_name)
-            except:
+            except Exception:
                 pass
         return DeleteImagesFromListResult(deleted_images=deleted_images)
-    except Exception as e:
+    except Exception:
         raise HTTPException(status_code=500, detail="Failed to delete images")
 
 
@@ -303,10 +303,10 @@ async def star_images_in_list(
             try:
                 ApiDependencies.invoker.services.images.update(image_name, changes=ImageRecordChanges(starred=True))
                 updated_image_names.append(image_name)
-            except:
+            except Exception:
                 pass
         return ImagesUpdatedFromListResult(updated_image_names=updated_image_names)
-    except Exception as e:
+    except Exception:
         raise HTTPException(status_code=500, detail="Failed to star images")
 
 
@@ -320,8 +320,8 @@ async def unstar_images_in_list(
             try:
                 ApiDependencies.invoker.services.images.update(image_name, changes=ImageRecordChanges(starred=False))
                 updated_image_names.append(image_name)
-            except:
+            except Exception:
                 pass
         return ImagesUpdatedFromListResult(updated_image_names=updated_image_names)
-    except Exception as e:
+    except Exception:
         raise HTTPException(status_code=500, detail="Failed to unstar images")

invokeai/app/api/routers/sessions.py

@@ -1,12 +1,13 @@
 # Copyright (c) 2022 Kyle Schouviller (https://github.com/kyle0654)
 
-from typing import Annotated, List, Optional, Union
+from typing import Annotated, Optional, Union
 
 from fastapi import Body, HTTPException, Path, Query, Response
 from fastapi.routing import APIRouter
 from pydantic.fields import Field
 
-from ...invocations import *
+# Importing * is bad karma but needed here for node detection
+from ...invocations import *  # noqa: F401 F403
 from ...invocations.baseinvocation import BaseInvocation
 from ...services.graph import (
     Edge,