Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new translations / Update old translations! #130

Open
inxomnyaa opened this issue Oct 3, 2019 · 22 comments
Open

Add new translations / Update old translations! #130

inxomnyaa opened this issue Oct 3, 2019 · 22 comments
Assignees
Labels
good first issue Hacktoberfest For the "Hacktoberfest" contributers Translation
Milestone

Comments

@inxomnyaa
Copy link
Owner

inxomnyaa commented Oct 3, 2019

πŸ“ New Translations

I want to introduce new translations and update current ones. Interested in "Hacktoberfest"? Here you can get started!

Any language is appreciated!

❓ How to contribute

  • Create a fork
  • Edit or add the corresponding file in /resources/lang, based on the english translation found here
  • If you modify an already existing language file, please make sure to remove entries that do not exist on eng.ini, and add those that are missing
  • Create a pull request and reference this issue (referencing is optional)
  • Pull Requests will be merged shortly before 30th October to leave you some time to correct translations (This does not influence Hacktoberfest, they are still counted if not merged)

Thanks to everyone who contributes!

πŸ—’ Notes & Guidelines

  • This is a Minecraft-related world editor, so some terms are special, i.e. "flood" has a similar meaning to the "Paint.exe paint bucket", and "Wand" is a region selection tool (See Translations!Β #64, there are several examples and explainations) (Please also check comments in this issue for some other special entries, like: Add new translations / Update old translations!Β #130 (comment))
  • The translation files must be named after the iso639-2 3-letter format (See https://www.loc.gov/standards/iso639-2/php/English_list.php)
  • The language.name key must be the "English Name of Language" entry from that website
  • Translation strings must be enclosed by " "
  • Readme may not be translated (too difficult to keep it updated)

❗ We had some discussions about some translation entries, so here is a heads-up on some things we have noticed:

  • Please make sure that {%0} is properly kept and do not contain spaces, those are text placeholders!
  • Make sure //togglewand and //toggledebug and similar entries with foregoing slashes are kept - those are commands
Translation key Explaination Reference
tool.debug.lore.2 Meta values are a Minecraft specific term #137 (comment)
ui.brush.options.flags Flags means "adding options" #150 (comment)
Biomes Biomes are a Minecraft specific term https://minecraft.gamepedia.com/Biome
Chunks Chunks are a Minecraft specific term https://minecraft.gamepedia.com/Chunk

πŸ’œ As always, enjoy Hacktoberfest!

Have fun and good luck with your πŸ‘•, Dan ❀

@inxomnyaa inxomnyaa added Hacktoberfest For the "Hacktoberfest" contributers Translation labels Oct 3, 2019
@inxomnyaa inxomnyaa added this to the 10.0.0 milestone Oct 3, 2019
@dingyifei
Copy link
Contributor

dingyifei commented Oct 4, 2019

Hi, I found the iso639-2 doesn't specify differences between Simplified Chinese and Traditional Chinese. Traditional Chinese is already taking the zho.ini file, should I use chi.ini or zh-s and rename zho.ini to zh-t.ini based on Wikipedia?
图片

@ooguz
Copy link

ooguz commented Oct 4, 2019

Turkish translation has come. #135

@Johnmacrocraft
Copy link
Contributor

Johnmacrocraft commented Oct 4, 2019

You'll probably want to use chs then, at least that's how this project handles it: https://github.com/pmmp/PocketMine-Language/blob/master/README.md

@Aericio Aericio closed this as completed Oct 4, 2019
@Aericio Aericio reopened this Oct 4, 2019
@Aericio
Copy link
Collaborator

Aericio commented Oct 4, 2019

My bad.

@msdeibel
Copy link

msdeibel commented Oct 4, 2019

For the German translation the formal and informal "you" (du/Sie) is mixed. Which one do you prefer?

@inxomnyaa
Copy link
Owner Author

Note: i changed the translations branch to be default to simplify it for the contributors, currently alot of people edited on master - please make sure to commit into translations!

Thanks so far!

@inxomnyaa
Copy link
Owner Author

For the German translation the formal and informal "you" (du/Sie) is mixed. Which one do you prefer?

I updated german myself personally, though i will change them to be all lowercase, thanks for the reminder

@inxomnyaa
Copy link
Owner Author

@inxomnyaa
Copy link
Owner Author

inxomnyaa commented Oct 9, 2019

We had some discussions about some translation entries, so here is a heads-up on some things we have noticed:

  • Please make sure that {%0} is properly kept and do not contain spaces, those are places were strings are inserted
  • Make sure //togglewand and //toggledebug and similar entries with foregoing slashes are kept - those are commands
Translation key Explaination Reference
tool.debug.lore.2 Meta values are a Minecraft specific term #137 (comment)
ui.brush.options.flags Flags means "adding options" #150 (comment)
Biomes Biomes are a Minecraft specific term https://minecraft.gamepedia.com/Biome
Chunks Chunks are a Minecraft specific term https://minecraft.gamepedia.com/Chunk

@GEveloper
Copy link
Contributor

@thebigsmileXD
Is the value of ui.flood.options.label.infoapply (line 92) correct ? Does not need to escape quotes like in command.brushname.set (line 36) ?

@inxomnyaa
Copy link
Owner Author

@GEveloper it appears to work anyways

@inxomnyaa
Copy link
Owner Author

It appears that Digitalocean finally sent email details about collecting the shirt!

Many thanks to everyone who contributed! Enjoy your shirt πŸ‘• and coding!

inxomnyaa added a commit that referenced this issue Dec 11, 2019
Update German translation as partial fix for #130.
inxomnyaa added a commit that referenced this issue Dec 22, 2019
@inxomnyaa
Copy link
Owner Author

All pull requests are merged - the branch will be merged. If you have any suggestions or translation updates, feel free to open a PR

@inxomnyaa inxomnyaa added good first issue and removed Hacktoberfest For the "Hacktoberfest" contributers State: In Review labels Dec 22, 2019
@inxomnyaa inxomnyaa pinned this issue Jan 29, 2020
@inxomnyaa inxomnyaa added the Hacktoberfest For the "Hacktoberfest" contributers label Oct 2, 2020
@inxomnyaa
Copy link
Owner Author

New contributions are welcome! (#hacktoberfest2020)

@dingyifei
Copy link
Contributor

dingyifei commented Oct 4, 2020

I'll update the Simplified Chinese translation, which branch should I use to create PR? (I assume the translation branch got merged into the master branch)

@inxomnyaa
Copy link
Owner Author

latest branch would be best, PM4 or feature-flip-rotate

@silvaromero
Copy link

silvaromero commented Oct 7, 2020

Is the Portuguese one updated? If it isn't, I can contribute by updating it. @thebigsmileXD

@nazmariam
Copy link

Hello, I can add Ukrainian translation. Should I?

@inxomnyaa
Copy link
Owner Author

Hello, I can add Ukrainian translation. Should I?

go ahead, we don't have it yet @nazmariam

Is the Portuguese one updated? If it isn't, I can contribute by updating it. @thebigsmileXD

It looks completed, but proof readers are always good @romeroclaudino

@inxomnyaa
Copy link
Owner Author

Feel free to contribute this year as well - new translation keys are being added very soon

Some changes to contributions: You shall natively speak the language you are translating to

@inxomnyaa inxomnyaa added Hacktoberfest For the "Hacktoberfest" contributers and removed Hacktoberfest For the "Hacktoberfest" contributers labels Oct 11, 2021
@bebora
Copy link
Contributor

bebora commented Oct 15, 2021

Hi! Which branch should we use as a reference for updated translations this year?

@inxomnyaa
Copy link
Owner Author

Hi! Which branch should we use as a reference for updated translations this year?

palette-preview would be the most recent

This was referenced Oct 24, 2021
@inxomnyaa inxomnyaa added Hacktoberfest For the "Hacktoberfest" contributers and removed Hacktoberfest For the "Hacktoberfest" contributers labels Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Hacktoberfest For the "Hacktoberfest" contributers Translation
Projects
None yet
Development

No branches or pull requests

10 participants