fix(page): remove waitFromAsync from beforeEach #501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is nothing async in the beforeEach to wait for as it is written. The other option would be to leave it in and then add in the closing parenthesis that is missing on line 12.
liamdebeasi
suggested changes
Nov 21, 2023
| @@ -5,7 +5,7 @@ describe('<%= classify(name) %>Page', () => { | |||
| let component: <%= classify(name) %>Page; | |||
| let fixture: ComponentFixture<<%= classify(name) %>Page>; | |||
|
|
|||
| beforeEach(waitForAsync () => { | |||
| beforeEach(() => { | |||
There was a problem hiding this comment.
Can we remove the waitForAsync import at the top of the file?
There was a problem hiding this comment.
Doh! Good catch... Fixed.
liamdebeasi
approved these changes
Nov 21, 2023
There was a problem hiding this comment.
Looks good to me. Verified that the calls we are making do not return a promise:
TestBed.createComponentreturnsComponentFixture: https://angular.io/api/core/testing/TestBed#createcomponentfixture.detectChanges()returnsvoid: https://angular.io/api/core/testing/ComponentFixture#detectchanges
sean-perkins
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is nothing async in the beforeEach to wait for as it is written.
The other option would be to leave it in and then add in the closing parenthesis that is missing on line 12.