Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove unused waitForAsync #505

Closed
wants to merge 1 commit into from
Closed

fix: remove unused waitForAsync #505

wants to merge 1 commit into from

Conversation

liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented Nov 29, 2023

The page spec test doesn't have any async code in the beforeEach block. Additionally, there's a missing ) that is causing a syntax error:

Error: src/app/my-page-2/my-page-2.page.spec.ts:8:33 - error TS2345: Argument of type '{ fixture: ComponentFixture<MyPage2Page>; component: MyPage2Page; "": any; }' is not assignable to parameter of type 'number'.

  8   beforeEach(waitForAsync () => {
                                    ~
  9     fixture = TestBed.createComponent(MyPage2Page);
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
... 
 11     fixture.detectChanges();
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 12   });
    ~~~


Error: src/app/my-page-2/my-page-2.page.spec.ts:9:51 - error TS1005: ',' expected.

9     fixture = TestBed.createComponent(MyPage2Page);
                                                    ~

This PR removes waitForAsync to avoid the error and remove the unused code.

@liamdebeasi liamdebeasi changed the title fix: remove unneeded waitForAsync chore: remove unused waitForAsync Nov 29, 2023
@liamdebeasi liamdebeasi changed the title chore: remove unused waitForAsync fix: remove unused waitForAsync Nov 29, 2023
@liamdebeasi liamdebeasi marked this pull request as ready for review November 29, 2023 16:13
@liamdebeasi
Copy link
Contributor Author

liamdebeasi commented Nov 30, 2023

I made this PR even after I reviewed and approved #501 which is an exact copy of this change 😂 . Closing in favor of the merged PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant