chore(iOS): Redefining bridge API #3678
Conversation
… updated umbrella headers, updated project settings, removed Capacitor project's Podfile. Updated respective podspecs to match.
…tub for CAPBridge.
ikeith
changed the title
ios/Capacitor/Capacitor/CAPLog.swift
Outdated
| public static func print(_ items: Any..., separator: String = " ", terminator: String = "\n") { | ||
| oneTimeConfigCheck() | ||
| if enableLogging { | ||
| if !self.hideLogs() { |
There was a problem hiding this comment.
I really don't understand why this is checked dynamically on every single log call — it's enormously wasteful, because the value can't change during runtime. It really should be a static value.
There was a problem hiding this comment.
This is reverting a workaround for a bug that appeared during testing (a different workaround is used for the time being). Eventually, it will be a static flag as configuration is revisited in support of #3182
|
Clicking "Fix" on these renames doesn't substitute the right thing. Any chance we could get this to work automatically? If they don't "just work" maybe we shouldn't use |
It looks like |
This branch has two goals:
Isolate the bridge behind a protocol so that the publicly exposed API can be easily parsed and understood. The scope of the old API was extremely difficult to grasp because of the lack of organization and unclear rules for cross-language (Swift <-> Obj-C) importation.
Update the exposed API to be more consistent and idiomatic while preserving backwards-compatibility wherever possible.
The first goal is accomplished through the declaration of the
CAPBridgeProtocol, which is what plugins have access to, and making the actual bridge and related objectsinternal. Making the bridge internal meant it needed to be renamed so a newCAPBridgeclass could be exposed to provide a stub for any static methods, in order to preserve backwards compatibility.The app delegate-related methods have been split into a separate object as they are independent functionality. And that new
AppDelegateProxyobject needs to be made public.