Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(iOS): updating bridge protocol #3831

Merged
merged 7 commits into from
Nov 23, 2020
Merged

chore(iOS): updating bridge protocol #3831

merged 7 commits into from
Nov 23, 2020

Conversation

ikeith
Copy link
Contributor

@ikeith ikeith commented Nov 19, 2020 •
edited
Loading

Follow-on branch to #3678, fixing some minor issues in the bridge protocol

  • Added public access level to extension methods that mistakenly inherited internal
  • Deprecated modulePrint and removed new print method from the bridge
  • Exposed and deprecated getLocalUrl method which will be superseded by a config property in feat(iOS): Refactoring configuration #3759

@ikeith ikeith mentioned this pull request Nov 20, 2020
Closed
@ikeith ikeith merged commit 667daf9 into main Nov 23, 2020
@ikeith ikeith deleted the cleanup branch November 23, 2020 16:41
@ikeith ikeith restored the cleanup branch November 23, 2020 16:41
@ikeith ikeith deleted the cleanup branch November 23, 2020 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcesarmobile jcesarmobile jcesarmobile approved these changes

@imhoffd imhoffd imhoffd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ikeith @imhoffd @jcesarmobile