Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(android): support sdk 19 version & intent:// url syntax #144

Closed
wants to merge 1 commit into from
Closed

feat(android): support sdk 19 version & intent:// url syntax #144

wants to merge 1 commit into from

Conversation

leo6104
Copy link
Contributor

@leo6104 leo6104 commented Aug 10, 2018

  1. When we use 3rd party payment system through iframe tag in android, their payment website try to open intent://open/payment ~ url pattern but it doesn't work because of unhandled method shouldOverrideUrlLoading. So, i override this method.
  2. Support Android SDK 19 by passing Uri url (remove WebResourceRequest class usage) & use older constructor via createWebResourceResponse method

@matejkramny
Copy link
Contributor

Amazing! We can go back to supporting kitkat users

@silaslira silaslira mentioned this pull request Aug 27, 2018
Closed
@jcesarmobile jcesarmobile mentioned this pull request Sep 11, 2018
Closed
@imhoffd imhoffd closed this in b399680 Sep 11, 2018
@imhoffd
Copy link
Contributor

imhoffd commented Sep 11, 2018

Thank you @leo6104! 🎉 The kitkat support has been merged via this PR: #168 and this commit: b399680

If you could create a separate PR with the intent stuff, that would be perfect.

@dependabot dependabot bot mentioned this pull request Mar 16, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leo6104 @matejkramny @imhoffd