Kitkat support #168
Closed
Kitkat support #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @jcesarmobile 👋, Great to see older versions of Android supported! 😀 This PR was for supporting KitKat. One thing that's throwing me off is the default value used in <variable name="ANDROID_SUPPORT_ANNOTATIONS_VERSION" value="27.+" />
Thank you so much for your time! 😃 |
|
That’s the version of the support library, has nothing to do with the supported android version, it’s for adding annotations support, which is required to work on kit kat |
|
Thank you so much for your prompt reply! 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebased and picked the KitKat support part of this #144
Also added the support annotation framework as it's needed to use
RequiresApi.Tested on 4.4 simulator and works fine, couldn't test on real device.