-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Page navs and overlays with tabs view will overlap with iOS statusbar #6368
Comments
Thanks for the issue! I'll look into this soon. |
Hmm I am not able to reproduce this in our e2e test (https://github.com/driftyco/ionic/tree/2.0/ionic/components/app/test/cordova) or in the conference app (https://github.com/driftyco/ionic-conference-app/). Is there anything else going on besides navigating to a new page inside of tabs? Here's a gif of what I see: http://g.recordit.co/BictqlhckJ.gif |
@brandyscarney I noticed the same issue. When I run my app in the simulator, I don't see it, but I get it when running it on iPad 2/ iPhone 5 with Ionic View. |
@abuechler Thank you for that info! I was able to reproduce it that way. 😄 I'll have to look into whether this issue is with the framework or the view app itself. Please let me know if anyone has steps to reproduce it in a simulator or on a device outside of view. Thanks! |
Also, @abuechler, as a temporary work around for it not working in view, you could set
|
@brandyscarney If it helps, I have |
I'm actually a bit unclear what that does - the documentation is a bit sparse on the subject: http://ionicframework.com/docs/v2/api/config/Config/ |
@brandyscarney Ok, that works. Thanks! |
@wli The I agree we need to add more documentation behind the config properties. I think this is something we'll fix with this issue: ionic-team/ionic-site#585 |
@abuechler I created an issue for the Ionic View app not showing the status bar padding. This is something that will have to be resolved in the Ionic View app itself: https://github.com/driftyco/ionic-view-issues/issues/164 |
This will be fixed in the |
I have same issue on beta.7 release in ios emulator on ipad2, iphone5 and others. Custom navbar component example: <div #content>
<ion-navbar *navbar>
<button menuToggle end>
<ion-icon name="menu"></ion-icon>
</button>
<ion-title>
Dashboards
</ion-title>
</ion-navbar>
</div>
<ion-menu side="right" [content]="content">
<ion-toolbar class="ion-menu-logo">
<ion-title>Menu</ion-title>
</ion-toolbar>
<ion-content>
<ion-list>
<button class="ion-menu-button"
ion-item
menuClose
(click)="logOut()">
<ion-icon item-left name="log-out"></ion-icon>
Log out...
</button>
</ion-list>
</ion-content>
</ion-menu> 'use strict';
import {IONIC_DIRECTIVES} from 'ionic-angular/config/directives';
import {Component} from '@angular/core';
import {AuthService} from '../../../shared/services/$http/core';
@Component({
selector: 'top-navbar',
templateUrl: 'build/components/navigation/top-navbar/top-navbar.html',
directives: [IONIC_DIRECTIVES]
})
export class TopNavBarComponent {
constructor(
private auth: AuthService
) {
}
public logOut() {
var self = this;
self.auth.logout();
}
} In CSS just change background: .toolbar-background {
background: rgba(255,255,255,0.5);
} Custom navbar component usage: <top-navbar></top-navbar>
<ion-content>
<h1>Dashboards page</h1>
</ion-content> Ionic info:
|
I was also able to reproduce with
|
This issue still exists. However, only pages that you push onto the tabs have this. Confirm on Ionic View and iOS emulator |
This is still an issue on iOS when setting , Ionic info:
|
Please check this out. It totally removed the entire 20px including bat indicator on top of the main area. Not something some of you may want, but it in my case it was good enough. |
Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out. |
Short description of the problem:
Page navs and overlays with tabs view will overlap with iOS statusbar. This was fixed for other views (in #6154), but doesn't work with tabs.
What behavior are you expecting?
It should not overlap.
Steps to reproduce:
nav.push
Other information: (e.g. stacktraces, related issues, suggestions how to fix, stackoverflow links, forum links, etc)
Originally addressed in #6154 via f45ddf9
As you can see, the new selector
ion-navbar-section.statusbar-padding > .toolbar
does not apply to the page inside the tab, since there is noion-navbar-section
.Cleanest solution seems to be creating a new rule
ion-tab ion-navbar.statusbar-padding.toolbar
, but I will leave it up to the ionic team to decide (maybe @brandyscarney can chime in here)Which Ionic Version? 2.0.0-beta.6
Run
ionic info
from terminal/cmd prompt: (paste output below)Cordova CLI: 6.1.1
Ionic Framework Version: 2.0.0-beta.6
Ionic CLI Version: 2.0.0-beta.25
Ionic App Lib Version: 2.0.0-beta.15
ios-deploy version: 1.8.5
ios-sim version: 5.0.8
OS: Mac OS X El Capitan
Node Version: v5.8.0
Xcode version: Xcode 7.3 Build version 7D175
The text was updated successfully, but these errors were encountered: