Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add windows mode defaults to the config API docs #585

Closed
brandyscarney opened this issue Apr 28, 2016 · 4 comments
Closed

docs: add windows mode defaults to the config API docs #585

brandyscarney opened this issue Apr 28, 2016 · 4 comments
Assignees
@brandyscarney
Labels
docs v2

Comments

@brandyscarney
Copy link
Member

http://ionicframework.com/docs/v2/api/config/Config/
@brandyscarney brandyscarney self-assigned this Apr 28, 2016
brandyscarney added a commit to ionic-team/ionic-framework that referenced this issue Apr 28, 2016
@brandyscarney
docs(config): update config with windows mode
49e1b20 
rearrange mode config so it is in alphabetical order

references ionic-team/ionic-site#585
@brandyscarney
Copy link
Member Author

brandyscarney commented Apr 28, 2016 •
edited
Loading

I updated the docs but with the additional column it is a little squeezed:

screen shot 2016-04-28 at 4 56 36 pm

Perry is thinking we move this to a separate doc, maybe one that goes over the modes more in detail and then link to it from config?

@mhartington
Copy link
Contributor

I like the idea. That does seem a bit tight

@brandyscarney
Copy link
Member Author

Another idea - what if the config API docs had just the property name & a description of the property, but the theming section documented the mode defaults?

@brandyscarney brandyscarney mentioned this issue May 2, 2016
Closed
@perrygovier
Copy link
Contributor

I like that idea. Make it so.

@perrygovier perrygovier added this to the Before "good" milestone May 6, 2016
brandyscarney added a commit to ionic-team/ionic-framework that referenced this issue May 11, 2016
@brandyscarney
docs(config): update config docs to include a description for each pr…
81cb0ff 
…operty

also updated the demo to use quotes around the values.

references ionic-team/ionic-site#585
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brandyscarney brandyscarney

Labels
docs v2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@perrygovier @mhartington @brandyscarney