fix(popover): ensure arrow always points to trigger el #24813
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build
) was run locally and any changes were pushednpm run lint
) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Popovers with
alignment="start"
or"end"
andarrow="true"
position the arrow in the center of the popover. This can cause the arrow to fall outside the trigger element.Issue URL: Resolves #24389
What is the new behavior?
For
start
andend
alignments, the popover's arrow is positioned at the center of the trigger element instead. Popovers without a trigger element, such as those presented through a controller, are not affected.Does this introduce a breaking change?
Other information
The difference is most obvious with small trigger elements, since those more easily cause the arrow to point at empty space.