fix(popover): default alignment to 'center' for ios mode #24815
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build
) was run locally and any changes were pushednpm run lint
) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Popovers always default to
alignment="start"
. This causes problems onios
mode when the trigger element is much smaller than the popover; the arrow falls outside the trigger element.Issue URL: Resolves #24389
What is the new behavior?
Popovers'
alignment
now defaults to"center"
onios
mode only. This matches the Ionic v5 behavior.Does this introduce a breaking change?
While changing the default value of
alignment
is technically a breaking change, this also technically fixes a regression from v5 where the defaults were as this PR makes them.Other information
There is another PR at #24813 that aimed to have the arrow always point at the center of the trigger element regardless of alignment, but the team decided it added too much complexity for what is ultimately a narrow use case.