Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(popover): default alignment to 'center' for ios mode #24815

Merged
merged 1 commit into from
Feb 18, 2022
Merged

Conversation

averyjohnston
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Popovers always default to alignment="start". This causes problems on ios mode when the trigger element is much smaller than the popover; the arrow falls outside the trigger element.

example

Issue URL: Resolves #24389

What is the new behavior?

Popovers' alignment now defaults to "center" on ios mode only. This matches the Ionic v5 behavior.

Does this introduce a breaking change?

  • Yes
  • No

While changing the default value of alignment is technically a breaking change, this also technically fixes a regression from v5 where the defaults were as this PR makes them.

Other information

There is another PR at #24813 that aimed to have the arrow always point at the center of the trigger element regardless of alignment, but the team decided it added too much complexity for what is ultimately a narrow use case.

@averyjohnston averyjohnston requested a review from a team as a code owner February 18, 2022 16:26
@github-actions github-actions bot added the package: core @ionic/core package label Feb 18, 2022
@sean-perkins sean-perkins requested a review from a team February 18, 2022 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Popover points arrow at incorrect position in iOS mode (Ionic 6)
3 participants