-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge Ionide changes upstream #110
Conversation
All changes look good to me! Just a bit concerned about the failing test:
It's for the unsaved files, I wonder why that could be broken. |
That's pretty weird. I can't reproduce this failing test on my machine (Windows) |
Funny, it does here on OSX, I'll try to work out why. |
So it turns out it is due to the new drive letter normalization you introduced. I did some instrumentation and found the following:
What is that normalization needed for? If it is definitely required then it needs to be applied to |
From what I remember, Atom returns paths with small letter for drive, VS Code with capital letter (Or other way round). I've thought it would be good idea to get it normalized in FSAC so it can work for any editor without any additional work on editor side. |
I see, OK, well if you propagate that through to FileSystem.fs that should fix this regression. |
Hey, thanks for help, added normalization there. |
project.json
(this probably will be dropped in futture but let's have it now)Lot of changes (sorry :( ) but all "production" tested on Ionide users ;)