-
-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
run ionide with .NET Core #78
Comments
I guess most important is FCS and FsAutoComplete. Would leave Forge out of equation for now. Changes in plugins would be really small. Big thing is making our language services working without mono installed. |
Is adding support for the .NET Core debugger possible? That would be so awesome! |
I think normal .Net Core debugging extension should / will work with F#. |
FCS just needs a port of fsyacc and fslexx, but other than that it works thanks to @enricosada last night for helping me with that. |
@Krzysztof-Cieslak Running without mono, would that just require a change to the command called by the plugin? |
@7sharp9, yes. It should be really easy to change. |
I started on porting fsautocomplete core, first issues are projectcracker and Fsharp.lint |
I think we can ignore FSharpLint for now ( just comment it out). ProjectCracker is important I guess. |
Yeah its a real pain for me working with no tools at all. :-( |
I started it here anyway if anyone want to help out: https://github.com/7sharp9/FsAutoComplete/tree/dotnetcore |
@enricosada / @Krzysztof-Cieslak
Its hard to figure out what its complaining about? |
projectcracker see fsharp/fsharp-compiler-docs#582 (comment) @7sharp9 amazing fast! |
@7sharp9 let me check the error |
@enricosada projectcracker is done, I just hadn't added the package via -f yet. |
@7sharp9 has issue, it's not using the right dependencies i think, see fsharp/fsharp-compiler-docs#583 |
@enricosada I just used a new project then added the files from fsauto to the list. The error here seems to be |
@7sharp9 cloning you repo atm |
Its hard to tell, it looks like the error message form the compiler has been clipped short. |
@7sharp9 fsharp/fsharp-compiler-docs@73c0796 was removed, check StaticParameters fsharp/fsharp-compiler-docs@73c0796#diff-d3c6e872b60cb8a91665cdd9d5e5ca27R303 |
Yeah just added an array length, that must be an API change in FCS, just pushed anyway. |
@enricosada Theres some TODO's and warnings left but it does build, ran out of time for now. fixes welcome :-) |
Guys, try also merging ionide/FsAutoComplete#110 up to dotnetcore branch. It's version currently used by Ionide. |
Ive ran out of time for now, if anyone gets a chance to forge ahead then that would be great. |
@7sharp9 i'll do a build to check in your repo |
Ok, down to last error on the suave project:
After that, just the todo's. |
I'll continue tomorrow.
Easier to merge as pr |
I'm pretty sure Also I would like to think how to deploy it with plugin. Omnisharp team produces separate releases for each platform (https://github.com/OmniSharp/omnisharp-roslyn/releases) and downloads appropriate version during plugin start. Why not create one release for all platforms? How big would be FSAC.Suave with all dependencies (in comparison to current)? Should we use .Net Core version also on Winodws? |
I've tried running
Do I need to do something more? |
Because it's easier do that for multiple plat. With So is better to have multiple versions, less disk size. Otherwise you need dotnet core installed in the PATH (not the experience you want, because you want to pin to a specific dotnet sdk)
check what feed |
I built fcs and cracker locally and used the -f option as Enrico mentioned. I guess when the PR is finished for fcs the nugget can be published. Not sure why it isn't yet.
|
I get that error, looks like msbuild stuff is still in there. |
I'll try to get fsharplint running on dotnet core this week |
@duckmatt If there are not many dependencies if should only take ten mins :-) |
Just ported the main fable project too
|
So now, we just need to port ionide to Fable ;) |
i added some notes, pls fix nuget.config and project.json as per https://github.com/dotnet/netcorecli-fsc/wiki/.NET-Core-SDK-preview1#notes . i'll send the pr to suave. |
I added some FAQ (netcore vs f#) in https://github.com/dotnet/netcorecli-fsc/wiki/FAQ @7sharp9 if you have a feedback about that, i'd really like to hear it because you converted already two proj (and that mean a solid second position as migrator 😄 ) Anyway, pls check the deps of the project, like in the faq:
otherwise ionide bundle it's going to be big 😄 |
@enricosada So you want me to tweak some settings, I'll have a look now. I think there are still msbuild ref issues in FCS too :-( I also ported fsharp-fable too ;-) |
@enricosada Im also using:
For publish to work in fsauto.suave |
I've got fsharplint running on dotnet core, are any projects using paket to create a nuget package for dotnet core, or is packaging to be done as a separate step with |
See suave (rake) or chessie (fake). But process is the same. |
Let me review it. For example build tools dev feed is not needed |
Thanks that'll be really helpful :) I'll take a look at using the same approach as chessie tonight |
@kontomondo fsharplint should be nearly ready to go once we have a dotnet core version of FCS on nuget |
Is it possible to use Ionide with only dotnet core F# now? Do I have to change any configuration for this? I'm using VSCode. |
It's not. You can use Ionide with dotnet core projects but you still need mono / .Net Framework to run language services. |
Will fsAutocomplete also have a problem understanding .Net core lib namespaces like AspnetCore? I'm assuming FsAutoComplete is assuming the namespaces in core are organized the same way they are in Mono right? |
@Krzysztof-Cieslak, first of all great thanks for the great work you're doing with Ionide! |
@cotyar no repl on .net core 1.0. will be implemented for .net core 2.0, ref roadmap dotnet/fsharp#2400 |
Thank you @enricosada. |
FSAC on .net core is WIP in ionide/FsAutoComplete#224 |
@duckmatt do you need help/review for |
WIP in #78 |
Following twitter discussion, what's missing to run ionide with .NET Core?
If it's in the roadmap to use .netcore, otherwise just close this issue, np
I understand atm .net core seem in flux, but works, netcore is going rtm end of month.
Tooling instead it's not going to improve a lot soon, so is project.json for some time until c# start use msbuild instead of project.json, and we need time after that to use it.
But support need time, so i understand if people want to wait.
from
paket.dependencies
ionide/ionide-vscode-helpers
ionide/FSharpFormatting.CLI
ionide/FsAutoComplete
fsprojects/Forge
(or can be excluded for now)ionide-fsgrammar
@Krzysztof-Cieslak i'd like to help to bootstrap the .net core support of F# projects, but i dont know what prioritize atm after suave.
The text was updated successfully, but these errors were encountered: