Fix docs #73
Fix docs #73
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
@kwilcox I feel bad for throwing a PR like this on you. Many commits, multiple "fixes" that makes the docs pass but doesn't really review them as I should, etc. However, I promise I'll find some time to properly review the docs in a future PR. At the moment, getting them to build and pass is what I can do 😬 |
|
@kwilcox this PR makes the docs pass but doesn't mean we want everything we have here. I'll send smaller PRs with the fixes specific problems to make it easier to review. Keeping this draft just as a reference. |
ocefpaf
force-pushed
the
fix_docs
branch
2 times, most recently
from
2aabba0 to
a8bfb61
Compare
ocefpaf
force-pushed
the
fix_docs
branch
2 times, most recently
from
602a460 to
3e3c2e2
Compare
|
@ocefpaf ready for review again? |
Not yet. I'm planning on decoupling the notebook changes from the rest to make it easier to review. Rebasing here just to make sure everything is passing before sending the non-notebook PR. |
ocefpaf
force-pushed
the
fix_docs
branch
3 times, most recently
from
ddbc30e to
c9a0931
Compare
| @@ -11,7 +11,7 @@ Here is a collection of other QARTOD implementations or contacts for reference. | |||
| Python | |||
|
|
|||
| - `Ocean Observatories Initiative (OOI) Quality Control Algorithm <https://github.com/ooici/ion-functions/tree/master/ion_functions/qc>`_ | |||
| - `OOI Quality Control Algorithm Tables <https://github.com/ooi-integration/qc-lookup>`_ | |||
| - `OOI Quality Control Algorithm Tables <https://github.com/oceanobservatories/qc-lookup>`_ | |||
There was a problem hiding this comment.
This just fixes a re-direct.
| @@ -8,7 +8,8 @@ You can download the source for these notebooks `here <https://github.com/ioos/i | |||
|
|
|||
| * :doc:`Read water level data from CSV into Pandas, run QARTOD tests, and plot results in Bokeh </examples/QartodTestExample_WaterLevel>` | |||
|
|
|||
| * :doc:`Run QARTOD on a netCDF file, and store the results </examples/Qartod_netCDF_example>` | |||
| .. | |||
| * :doc:`Run QARTOD on a netCDF file, and store the results </examples/Qartod_netCDF_example>` | |||
There was a problem hiding this comment.
We need to re-run all these notebooks and make sure they are updated. I'm skipping them for now b/c I could not make them work.
This one is built on top of #70 but we should not merge this one yet. I "fixed" so many things that we may need to discuss if all these changes actually make sense.