Use geographiclib in lieu of pyproj #75
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Geographiclib is a stable, well maintained, and pure python library. We only use pyproj here for the great_distance calculation, so we should be OK with this change.
The results are similar and geographiclib algorithms do not suffer from this issue. See for a poor man's comparison https://nbviewer.org/gist/ocefpaf/7d290f94e5ffec1af560ded41d8c0dd1
Closes #72.
PS: only the doc build is failing. That should be fixed in #73.