Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update for xarray new map_index_queries #78

Merged
merged 5 commits into from
Sep 22, 2022
Merged

Conversation

ocefpaf
Copy link
Member

@ocefpaf ocefpaf commented Jul 28, 2022

Closes #77

@kwilcox any chance this will get me some credit and a review on #71 and #75 😜

@ocefpaf
Copy link
Member Author

ocefpaf commented Jul 29, 2022

This PR makes it py>=38 only. I can push and alternative that makes it py>=36 if you think it is useful.

@kthyng
Copy link

kthyng commented Jul 29, 2022

@ocefpaf including Python 3.7 would be useful for me

@ocefpaf
Copy link
Member Author

ocefpaf commented Aug 1, 2022

@ocefpaf including Python 3.7 would be useful for me

Latest commit re-adds it. I added some comments on the code that needs to be removed when dropping 3.7

@kwilcox kwilcox merged commit cf4dc18 into ioos:master Sep 22, 2022
@kwilcox
Copy link
Member

kwilcox commented Sep 22, 2022

😆 on a random computer without pre-commit installed. The shame I feel is immense.

@ocefpaf ocefpaf deleted the update_xarray branch September 22, 2022 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python 3.8 ioos_qc leads to an ImportError with xarray, but Python 3.7 does not.
3 participants