Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ImmutableAliasAddressUnlockCondition #1101

Merged
merged 6 commits into from
Feb 8, 2022
Merged

Add ImmutableAliasAddressUnlockCondition #1101

merged 6 commits into from
Feb 8, 2022

Conversation

thibault-martinez
Copy link
Member

@thibault-martinez thibault-martinez commented Feb 7, 2022 •
edited
Loading

iotaledger/tips@d9a0416

Change checklist

Tick the boxes that are relevant to your changes, and delete any items that are not.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes
  • I have updated the CHANGELOG.md, if my changes are significant enough

@thibault-martinez thibault-martinez added c-feature Category - Feature e-medium Experience - Medium n-shimmer Network - Shimmer p-medium Priority - Medium wg-message Working Group - Message labels Feb 7, 2022
@thibault-martinez thibault-martinez mentioned this pull request Feb 7, 2022
Closed
11 tasks
samuel-rufi
samuel-rufi previously approved these changes Feb 7, 2022
View reviewed changes
Alex6323
Alex6323 previously approved these changes Feb 7, 2022
View reviewed changes
Thoralf-M
Thoralf-M previously approved these changes Feb 7, 2022
View reviewed changes
@samuel-rufi samuel-rufi self-requested a review February 8, 2022 08:25
Adam-Gleave
Adam-Gleave approved these changes Feb 8, 2022
View reviewed changes
bee-api/bee-rest-api/src/types/dtos.rs
Comment on lines +978 to +981
serde::de::Error::custom(format!(
"cannot deserialize immutable alias address unlock condition: {}",
e
))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rustfmt why

@thibault-martinez thibault-martinez merged commit 33d1117 into iotaledger:shimmer-develop Feb 8, 2022
@thibault-martinez thibault-martinez deleted the immutable-feature-blocks branch February 8, 2022 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samuel-rufi samuel-rufi samuel-rufi approved these changes

@Adam-Gleave Adam-Gleave Adam-Gleave approved these changes

@Thoralf-M Thoralf-M Thoralf-M approved these changes

@Alex6323 Alex6323 Alex6323 left review comments

@bingyanglin bingyanglin Awaiting requested review from bingyanglin

Assignees
No one assigned
Labels
c-feature Category - Feature e-medium Experience - Medium n-shimmer Network - Shimmer p-medium Priority - Medium wg-message Working Group - Message
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@thibault-martinez @samuel-rufi @Adam-Gleave @Alex6323 @Thoralf-M