Update TSC to compare tangle time with time of confirmed message. #2167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
georgysavva
reviewed
May 9, 2022
packages/tangle/tipmanager.go
Outdated
| @@ -363,8 +363,7 @@ func (t *TipManager) Tips(p payload.Payload, countParents int) (parents MessageI | |||
| } | |||
|
|
|||
| func (t *TipManager) isPastConeTimestampCorrect(messageID MessageID) (timestampValid bool) { | |||
| now := clock.SyncedTime() | |||
| minSupportedTimestamp := now.Add(-t.tangle.Options.TimeSinceConfirmationThreshold) | |||
| minSupportedTimestamp := t.tangle.TimeManager.Time().Add(-t.tangle.Options.TimeSinceConfirmationThreshold) | |||
There was a problem hiding this comment.
With the new time types (CTT, RCTT, FTT, RFTT) added to the TimeManager, you might want to change that condition.
karimodm
reviewed
May 20, 2022
| // if closest past marker is confirmed and before minSupportedTimestamp, then message should be ok | ||
| return true | ||
| // if closest past marker is confirmed and before minSupportedTimestamp, then need to walk message past cone of the previously marker message | ||
| messageWalker.Push(previousMessageID) |
There was a problem hiding this comment.
We needed to push the message to the messageWalker to evaluate it; before we were just assuming that if the closest marker was confirmed the message was ok.
Merged
karimodm
approved these changes
May 23, 2022
| // if closest past marker is confirmed and before minSupportedTimestamp, then message should be ok | ||
| return true | ||
| // if closest past marker is confirmed and before minSupportedTimestamp, then need to walk message past cone of the previously marker message | ||
| messageWalker.Push(previousMessageID) |
There was a problem hiding this comment.
We needed to push the message to the messageWalker to evaluate it; before we were just assuming that if the closest marker was confirmed the message was ok.
* Add CTT, FTT. Rename Synced to Bootstrapped * Add RCTT and RFTT to time manager * Change sync logic to bootstrap * Add new time types to the API responses * Use RCTT for activity window * Review fixes * Review fixes * Use to distinct states for bootstrapped and synced * Add bootstrapped check * Change RCTT calculation * Issue metrics only when node is synced. Co-authored-by: Daria Dziubałtowska <daria.dziubaltowska@iota.org> Co-authored-by: Piotr Macek <piotr.macek@iota.org>
georgysavva
approved these changes
Jun 2, 2022
jonastheis
reviewed
Jun 17, 2022
Co-authored-by: Jonas Theis <4181434+jonastheis@users.noreply.github.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
jonastheis
approved these changes
Jun 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Solves #2160
Type of change
Choose a type of change, and delete any options that are not relevant.
How the change has been tested
Describe the tests that you ran to verify your changes.
Make sure to provide instructions for the maintainer as well as any relevant configurations.
Unit tests, manual testing.
Change checklist
Add an
xto the boxes that are relevant to your changes, and delete any items that are not.