Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(wallet-dashboard): style selected visual Assets #4085

Merged
merged 29 commits into from
Dec 4, 2024
Merged

feat(wallet-dashboard): style selected visual Assets #4085

merged 29 commits into from
Dec 4, 2024

Conversation

panteleymonchuk
Copy link
Contributor

@panteleymonchuk panteleymonchuk commented Nov 15, 2024 •
edited
Loading

Description of change

Please write a summary of your changes and why you made them.

Links to any relevant issues

Closes #3702
Closes #3703

Depends on #4159 because in the file useNftDetails.ts:18 we have flag isTransferable (not critical)

Be sure to reference any related issues by adding fixes #(issue).

Type of change

Choose a type of change, and delete any options that are not relevant.

  • Bug fix (a non-breaking change which fixes an issue)
  • Enhancement (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Fix

How the change has been tested

Describe the tests that you ran to verify your changes.

Make sure to provide instructions for the maintainer as well as any relevant configurations.

Change checklist

Tick the boxes that are relevant to your changes, and delete any items that are not.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

@panteleymonchuk panteleymonchuk added the tooling Issues related to the Tooling team label Nov 15, 2024
@panteleymonchuk panteleymonchuk changed the title feat(wallet-dashboard): show details for Assets. feat(wallet-dashboard): style selected visual Assets. Nov 15, 2024
@panteleymonchuk panteleymonchuk linked an issue Nov 15, 2024 that may be closed by this pull request
Style selected visual asset #3702
Closed
@begonaalvarezd begonaalvarezd added the wallet-dashboard Issues related to the Wallet Dashboard dApp label Nov 18, 2024
@panteleymonchuk panteleymonchuk force-pushed the tooling-dashboard/style-selected-asset branch from 029d55d to 3e6609a Compare November 19, 2024 15:35
@panteleymonchuk panteleymonchuk marked this pull request as ready for review November 19, 2024 15:35
@panteleymonchuk panteleymonchuk requested review from a team as code owners November 19, 2024 15:35
@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 3e6609a

✅ Preview: https://apps-ui-k3bwiq3s3-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 3e6609a

✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-eh61zw26s.vercel.app

@panteleymonchuk panteleymonchuk force-pushed the tooling-dashboard/style-selected-asset branch from 3e6609a to 093c3f4 Compare November 21, 2024 17:05
@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 093c3f4

✅ Preview: https://apps-ui-gmb4m6m9l-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 093c3f4

✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-9zytokc9d.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: b3291fb

✅ Preview: https://apps-ui-hqd7rines-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: b3291fb

✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-eqvcvqz9h.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: b3291fb

✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-em3q1ti7k.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: b3291fb

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-715v9b7bi.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: b15c9e8

✅ Preview: https://apps-ui-r3abi1al2-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: b15c9e8

✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-omixq143z.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: b15c9e8

✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-aw4xjm5cp.vercel.app

@marc2332 marc2332 self-requested a review November 25, 2024 15:23
marc2332
marc2332 requested changes Nov 25, 2024
View reviewed changes
apps/core/src/hooks/useNftDetails.ts Outdated Show resolved Hide resolved
apps/core/src/hooks/useNftDetails.ts Outdated Show resolved Hide resolved
apps/core/src/hooks/useNftDetails.ts Outdated Show resolved Hide resolved
apps/wallet-dashboard/components/Collapsible/Collapsible.tsx Outdated Show resolved Hide resolved
Base automatically changed from tooling-dashboard/style-selected-stake to develop November 25, 2024 16:20
VmMad
VmMad reviewed Dec 4, 2024
View reviewed changes
Copy link
Member

@VmMad VmMad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lookg good to me! Nice job 🥇

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 4, 2024

This pull request has been deployed to Vercel.

Latest commit: 1848cc5

✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-603hsnr64.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 4, 2024

This pull request has been deployed to Vercel.

Latest commit: 78517ee

✅ Preview: https://apps-ui-evt7euwi7-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 4, 2024

This pull request has been deployed to Vercel.

Latest commit: 78517ee

✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-1qmlavems.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 4, 2024

This pull request has been deployed to Vercel.

Latest commit: 78517ee

✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-fif98mo53.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 4, 2024

This pull request has been deployed to Vercel.

Latest commit: 78517ee

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-o5skgx298.vercel.app

begonaalvarezd
begonaalvarezd requested changes Dec 4, 2024
View reviewed changes
apps/core/src/hooks/useNftDetails.ts Outdated Show resolved Hide resolved
apps/wallet-dashboard/app/(protected)/assets/page.tsx Outdated Show resolved Hide resolved
apps/wallet-dashboard/app/(protected)/assets/page.tsx Outdated Show resolved Hide resolved
apps/wallet-dashboard/components/Dialogs/Assets/AssetDialog.tsx Outdated Show resolved Hide resolved
apps/wallet-dashboard/components/Dialogs/Assets/views/DetailsView.tsx Outdated Show resolved Hide resolved
apps/wallet-dashboard/components/Dialogs/Assets/views/DetailsView.tsx Outdated Show resolved Hide resolved
apps/wallet/src/ui/app/pages/home/nft-details/index.tsx Outdated Show resolved Hide resolved
apps/wallet/src/ui/app/pages/home/nft-details/index.tsx Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 4, 2024

This pull request has been deployed to Vercel.

Latest commit: 4d2d4c5

✅ Preview: https://apps-ui-fhzp3vu4f-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 4, 2024

This pull request has been deployed to Vercel.

Latest commit: 4d2d4c5

✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-r4n8v7ns6.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 4, 2024

This pull request has been deployed to Vercel.

Latest commit: 4d2d4c5

✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-lbpvs0f31.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 4, 2024

This pull request has been deployed to Vercel.

Latest commit: 4d2d4c5

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-ojmmp8zgl.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 4, 2024

This pull request has been deployed to Vercel.

Latest commit: 18789db

✅ Preview: https://apps-ui-qdeg3eisd-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 4, 2024

This pull request has been deployed to Vercel.

Latest commit: 18789db

✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-3u7lqlg6d.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 4, 2024

This pull request has been deployed to Vercel.

Latest commit: 18789db

✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-jy5e5tzj8.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 4, 2024

This pull request has been deployed to Vercel.

Latest commit: 18789db

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-hegkzw02f.vercel.app

brancoder
brancoder approved these changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@brancoder brancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎊

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 4, 2024

This pull request has been deployed to Vercel.

Latest commit: e1ad666

✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-k7kcdqsvk.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 4, 2024

This pull request has been deployed to Vercel.

Latest commit: e1ad666

✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-6xueuvi3d.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 4, 2024

This pull request has been deployed to Vercel.

Latest commit: e1ad666

✅ Preview: https://apps-ui-5a4xsvx3o-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 4, 2024

This pull request has been deployed to Vercel.

Latest commit: e1ad666

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-jwnzer6jg.vercel.app

@begonaalvarezd begonaalvarezd merged commit c7aa8e5 into develop Dec 4, 2024
34 checks passed
@begonaalvarezd begonaalvarezd deleted the tooling-dashboard/style-selected-asset branch December 4, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VmMad VmMad VmMad approved these changes

@evavirseda evavirseda evavirseda approved these changes

@brancoder brancoder brancoder approved these changes

@marc2332 marc2332 marc2332 approved these changes

@begonaalvarezd begonaalvarezd begonaalvarezd approved these changes

Assignees
No one assigned
Labels
tooling Issues related to the Tooling team wallet-dashboard Issues related to the Wallet Dashboard dApp
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Style send visual asset Style selected visual asset
6 participants
@panteleymonchuk @begonaalvarezd @marc2332 @brancoder @evavirseda @VmMad