Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): Add hook with logic to check if an asset is 'Transferable'. #4159

Merged
merged 5 commits into from
Nov 29, 2024
Merged

feat(core): Add hook with logic to check if an asset is 'Transferable'. #4159

merged 5 commits into from
Nov 29, 2024

Conversation

msarcev
Copy link
Contributor

@msarcev msarcev commented Nov 20, 2024

Description of change

  • Add new hook way
  • Remove old util function way

Links to any relevant issues

Closes #3962

@msarcev msarcev added the tooling Issues related to the Tooling team label Nov 20, 2024
@msarcev msarcev requested review from a team as code owners November 20, 2024 11:47
@msarcev msarcev requested a review from marc2332 November 20, 2024 11:48
@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 306d178

✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-gjwqgkhkp.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 306d178

✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-5aycgvy42.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 306d178

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-mwheq3eim.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: f922246

✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-k1u63k2b6.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: f922246

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-9g76m5iuj.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: f922246

✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-1vmox2c50.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 98d9e72

✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-pkoh8xaqw.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 98d9e72

✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-1yncvxige.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 98d9e72

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-a3ihx0a83.vercel.app

@begonaalvarezd begonaalvarezd added the wallet Issues related to the IOTA Wallet label Nov 20, 2024
brancoder
brancoder previously requested changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@brancoder brancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

conflicts 🙏

@msarcev
Merge branch 'develop' into tooling-core/fix-is-asset-transferable-util
8f0fe94 
 Conflicts:
	apps/wallet-dashboard/app/(protected)/assets/[objectId]/page.tsx
	apps/wallet-dashboard/app/(protected)/assets/visual-assets/[objectId]/page.tsx
@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 8f0fe94

✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-j2608i3ot.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 8f0fe94

✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-auvprvfej.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 8f0fe94

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-grm962dkt.vercel.app

@VmMad VmMad requested a review from brancoder November 25, 2024 12:15
begonaalvarezd
begonaalvarezd approved these changes Nov 25, 2024
View reviewed changes
Copy link
Member

@begonaalvarezd begonaalvarezd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@panteleymonchuk panteleymonchuk mentioned this pull request Nov 26, 2024
Merged
6 tasks
@marc2332 marc2332 changed the title feat(core): Add hook with logic to check if an asset is 'Transferabe'. feat(core): Add hook with logic to check if an asset is 'Transferable'. Nov 27, 2024
@msarcev msarcev requested a review from marc2332 November 28, 2024 17:06
@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 2e846f0

✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-f8kjg18ma.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 2e846f0

✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-66m0953up.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 2e846f0

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-cry29y24i.vercel.app

@msarcev msarcev merged commit d899a6c into develop Nov 29, 2024
33 checks passed
@msarcev msarcev deleted the tooling-core/fix-is-asset-transferable-util branch November 29, 2024 09:50
@msarcev msarcev mentioned this pull request Nov 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@panteleymonchuk panteleymonchuk panteleymonchuk approved these changes

@begonaalvarezd begonaalvarezd begonaalvarezd approved these changes

@brancoder brancoder Awaiting requested review from brancoder

@marc2332 marc2332 Awaiting requested review from marc2332

Assignees
No one assigned
Labels
tooling Issues related to the Tooling team wallet Issues related to the IOTA Wallet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update isAssetTransferable logic to use getNormalizedMoveStruct
5 participants
@msarcev @begonaalvarezd @panteleymonchuk @marc2332 @brancoder