Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow ioctl to show the list of actions for an account #2567

Closed
simonerom opened this issue Feb 1, 2021 · 6 comments · Fixed by #2750
Closed

Allow ioctl to show the list of actions for an account #2567

simonerom opened this issue Feb 1, 2021 · 6 comments · Fixed by #2750
Assignees
Labels
bug Something isn't working

Comments

@simonerom
Copy link
Member

simonerom commented Feb 1, 2021

What would you like to be added:
ioctl account actions ADDRESS|ALIAS [ SKIP [FIRST] ]

At least it returns (for each tx):
count + type + status + recipient + amount + hash

# lists all actions sorted from the most recent
$ ioctl account actions myAccount 

# lists all actions sorted from the most recent, skipping the latest 10
$ ioctl account actions myAccount 10 

# lists the most recent action
$ ioctl account actions myAccount 0 1 

# Example
12 transfer success io1jsljstd5xt62gzyde0usvqdjyf4vhh8peks9lf 12 IOTX ca01376611a11215589aaa664f71c8e466a5b5288438e50026f977e6928e2c48

Why is this needed:
When web explorers fail, we need a way to still be able to explore wallet transactions, then we useioctl account action hashto get more details on each transaction

@simonerom simonerom added enhancement New feature or request ioctl labels Feb 1, 2021
@millken millken self-assigned this Feb 4, 2021
@millken
Copy link
Contributor

millken commented Feb 4, 2021

pr #2568 submitted

@simonerom
Copy link
Member Author

simonerom commented Feb 22, 2021

I tested the command and it works fine, but it seems to not include all actions: specifically if we take https://iotexscan.io/address/<address> explorer view as a reference, the ioctl command seems to only include actions that are listed in the "Total Actions" tab, but all actions in the "Contract Actions" tab seem not to be included.

Assuming that the XRC20 and NFT actions are already included (it looks like so), can we also include the Contract Actions in the output?

@simonerom simonerom reopened this Feb 22, 2021
@millken
Copy link
Contributor

millken commented Feb 22, 2021

I will check it later, can you give some example address?

@simonerom
Copy link
Member Author

I will check it later, can you give some example address?

Sure: let's take this address as an example: https://iotexscan.io/address/io1jzdxuv7etyfvs7th7jwyspswr6y660zjd7lykg

the command ioctl account actions io1jzdxuv7etyfvs7th7jwyspswr6y660zjd7lykg --limit 138 returns all the 138 actions that you can see on the iotexscan account summary.
In fact, iotexscan shows 138 actions, and these 138 actions are listed in the Total Actions tab:

image

But these 138 are not all the actions, they seem to be all transfers and executions initiated by the user plus all the IOTX received, but they do not include the actions listed in the Contract Actions tab (IOTX received by a contract, like HERMES or ByrnDrop for example): as you can see there are 360 actions listed in the Contract Actions tab, that are not included in the "Total Actions" tab in iotexscan, and they are not included in the ioctl output as well.

We should provide, at least in ioctl, a raw list of all actions related to an address for the user to do its own filtering and calculations.

@millken
Copy link
Contributor

millken commented Feb 23, 2021

Total Actions” and “Contract Actions” show different fields, maybe we can add a parameter(or another command) to show “Contract Actions”'s actions.

@raullenchai raullenchai assigned Liuhaai and unassigned millken Jun 7, 2021
@raullenchai raullenchai removed the enhancement New feature or request label Jun 11, 2021
@Liuhaai Liuhaai added bug Something isn't working and removed ioctl labels Jun 16, 2021
@Liuhaai Liuhaai removed the v1.3 label Jul 13, 2021
@Liuhaai Liuhaai removed their assignment Jul 13, 2021
@Liuhaai
Copy link
Member

Liuhaai commented Jul 13, 2021

This issue will be fixed after the release of iotex-analytics v2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants