Allow ioctl to show the list of actions for an account #2750

Liuhaai · 2021-07-29T05:45:32Z

…nto issue#2730v2

todo · 2021-07-29T05:45:35Z

remove struct definition after the release of anlytics v2

iotex-core/ioctl/cmd/account/accountactions.go

Lines 42 to 47 in 4d67d90

 // TODO: remove struct definition after the release of anlytics v2 

 type AllActionsByAddressResult struct { 

 ActHash string 

 BlkHeight string 

 Sender string 

 Recipient string

This comment was generated by todo based on a `TODO` comment in `4d67d90` in #2750. cc @Liuhaai.

codecov · 2021-07-29T11:15:08Z

Codecov Report

Merging #2750 (095937a) into master (d10dabe) will increase coverage by 0.15%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #2750      +/-   ##
==========================================
+ Coverage   57.87%   58.02%   +0.15%     
==========================================
  Files         245      245              
  Lines       22414    22356      -58     
==========================================
  Hits        12973    12973              
+ Misses       7791     7733      -58     
  Partials     1650     1650

Impacted Files	Coverage Δ
ioctl/cmd/account/accountactions.go	`0.00% <0.00%> (-1.79%)`	⬇️
db/trie/mptrie/branchnode.go	`84.31% <0.00%> (+1.30%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d10dabe...095937a. Read the comment docs.

dustinxie · 2021-08-10T16:38:50Z

can you test this with couple of addresses to see if it works as expected?

Liuhaai · 2021-08-11T03:21:12Z

can you test this with couple of addresses to see if it works as expected?

Yes, It works as expected.

ioctl/cmd/account/accountactions.go

ioctl/config/config.go

millken

good job

* saving, switch to linux * tracing grpc api * saving, switch to linux * tracing grpc api * update tracer.go for test * small change * fix comments * Squashed commit of the following: commit 77a5a15 Author: dustinxie <dahuaxie@gmail.com> Date: Tue Oct 5 23:34:52 2021 -0700 [api] add cache for ReadContract/State() (#2827) commit 7d9bf96 Author: Haaai <55118568+Liuhaai@users.noreply.github.com> Date: Tue Oct 5 17:31:37 2021 -0700 bump Go to 1.17 (#2784) commit 09ef379 Author: dustinxie <dahuaxie@gmail.com> Date: Tue Oct 5 16:46:49 2021 -0700 [ioctl] display chainID and encoding (#2820) commit c2eab8d Author: Haaai <55118568+Liuhaai@users.noreply.github.com> Date: Tue Oct 5 15:45:45 2021 -0700 fix ioctl accountDelete test (#2825) commit 9489b57 Author: dustinxie <dahuaxie@gmail.com> Date: Tue Oct 5 15:14:31 2021 -0700 remove unnecessary WithFeatureCtx() (#2823) commit 3933ae9 Author: dayuanc <34013965+dayuanc@users.noreply.github.com> Date: Tue Oct 5 07:40:32 2021 -0700 limit the pagination size for all API calls to 5000 -- 2781 (#2800) Co-authored-by: dayuanc <wentaicui@WENTAIs-MacBook-Pro.local> Co-authored-by: CoderZhi <thecoderzhi@gmail.com> Co-authored-by: Raullen Chai <raullenchai@gmail.com> commit 88d273d Author: dayuanc <34013965+dayuanc@users.noreply.github.com> Date: Mon Oct 4 10:51:54 2021 -0700 Add unit tests to cover the functions in action/signedaction.go (#2824) commit ebe895c Author: dustinxie <dahuaxie@gmail.com> Date: Thu Sep 30 15:32:52 2021 -0700 [reward] extend foundation bonus (#2785) commit baa0a92 Author: CoderZhi <thecoderzhi@gmail.com> Date: Tue Sep 28 14:09:44 2021 -0700 Fix codecov (#2813) commit 84f06d3 Author: dayuanc <34013965+dayuanc@users.noreply.github.com> Date: Tue Sep 28 12:17:47 2021 -0700 reduce unnecessary logs for mainnet (#2808) * downgrade some unnecessary error and info logs * fix comments Co-authored-by: Raullen Chai <raullenchai@gmail.com> commit a245185 Author: dustinxie <dahuaxie@gmail.com> Date: Mon Sep 27 15:27:59 2021 -0700 [evm] panic in AccessList API (#2816) commit 8eec1b7 Author: dustinxie <dahuaxie@gmail.com> Date: Mon Sep 27 11:01:34 2021 -0700 set Jutland to activate at 10-11-2021 3pm PDT (#2812) Co-authored-by: Raullen Chai <raullenchai@gmail.com> commit e89be88 Author: CoderZhi <thecoderzhi@gmail.com> Date: Sat Sep 25 22:51:54 2021 -0700 set target height (#2807) Co-authored-by: dustinxie <dahuaxie@gmail.com> commit dba4993 Author: CoderZhi <thecoderzhi@gmail.com> Date: Thu Sep 23 11:44:26 2021 -0700 change commit block failure log level to error (#2810) commit 0459a1f Author: mas walker <handsome.void@gmail.com> Date: Wed Sep 22 20:18:23 2021 +0800 unbound feature and version/height (#2768) * unbound feature and version/height Co-authored-by: Raullen Chai <raullenchai@gmail.com> commit c1cea44 Author: millken <millken@gmail.com> Date: Tue Sep 21 06:31:57 2021 +0800 update circleci config, using golang 1.16.6 #2789 (#2791) Co-authored-by: dustinxie <dahuaxie@gmail.com> commit f245109 Author: Dustin Xie <dahuaxie@gmail.com> Date: Mon Sep 20 09:54:38 2021 -0700 [evm] enable opCall fix at Jutland height commit 3eea5b7 Author: Dustin Xie <dahuaxie@gmail.com> Date: Mon Sep 20 12:11:36 2021 -0700 [evm] fix datacopy.json for TestIstanbul commit 0641db0 Author: CoderZhi <thecoderzhi@gmail.com> Date: Fri Sep 17 14:37:28 2021 -0700 [evm] fix snapshot bug (#2802) * fix snapshot bug * add unit test Co-authored-by: Raullen Chai <raullenchai@gmail.com> commit e0683e8 Author: Haaai <55118568+Liuhaai@users.noreply.github.com> Date: Sat Sep 18 01:34:12 2021 +0800 add datacopy contract test (#2788) * add datacopy test * modify contract * remove debug log * update testdata * add attack bytecode * update datacopy.json * correct code format * remove printStore() in datacopy.sol * update contract test data Co-authored-by: dustinxie <dahuaxie@gmail.com> commit 44e0a68 Author: Haaai <55118568+Liuhaai@users.noreply.github.com> Date: Fri Sep 17 15:31:29 2021 +0800 Allow ioctl to show the list of actions for an account (#2750) * [ioctl] allow ioctl to show the list of actions for an account commit d10dabe Author: Haaai <55118568+Liuhaai@users.noreply.github.com> Date: Fri Sep 17 12:08:33 2021 +0800 [api] fix gas estimation calc bug (#2786) * fixed gas estimation bug in api.go * Tracing (#2) * [reward] extend foundation bonus (#2785) * Add unit tests to cover the functions in action/signedaction.go (#2824) * limit the pagination size for all API calls to 5000 -- 2781 (#2800) Co-authored-by: dayuanc <wentaicui@WENTAIs-MacBook-Pro.local> Co-authored-by: CoderZhi <thecoderzhi@gmail.com> Co-authored-by: Raullen Chai <raullenchai@gmail.com> * remove unnecessary WithFeatureCtx() (#2823) * fix ioctl accountDelete test (#2825) * [ioctl] display chainID and encoding (#2820) * bump Go to 1.17 (#2784) * [api] add cache for ReadContract/State() (#2827) Co-authored-by: dustinxie <dahuaxie@gmail.com> Co-authored-by: dayuanc <34013965+dayuanc@users.noreply.github.com> Co-authored-by: dayuanc <wentaicui@WENTAIs-MacBook-Pro.local> Co-authored-by: CoderZhi <thecoderzhi@gmail.com> Co-authored-by: Raullen Chai <raullenchai@gmail.com> Co-authored-by: Haaai <55118568+Liuhaai@users.noreply.github.com> Co-authored-by: Raullen Chai <raullenchai@gmail.com> Co-authored-by: dustinxie <dahuaxie@gmail.com> Co-authored-by: dayuanc <34013965+dayuanc@users.noreply.github.com> Co-authored-by: dayuanc <wentaicui@WENTAIs-MacBook-Pro.local> Co-authored-by: CoderZhi <thecoderzhi@gmail.com> Co-authored-by: Haaai <55118568+Liuhaai@users.noreply.github.com>

Liuhaai added 3 commits July 28, 2021 11:44

remove test account file

926f018

Merge branch 'master' of https://github.com/iotexproject/iotex-core i…

b541be5

…nto issue#2730v2

fix issue#2567

4d67d90

Liuhaai requested a review from a team as a code owner July 29, 2021 05:45

fix struct name issue

3ab5213

Liuhaai force-pushed the issue#2567v2 branch from 649abe8 to 3ab5213 Compare July 29, 2021 10:59

remove unused variables

20ca05e

Merge branch 'master' into issue#2567v2

7c4e749

raullenchai requested a review from millken August 23, 2021 05:14

millken reviewed Aug 24, 2021

View reviewed changes

ioctl/cmd/account/accountactions.go Outdated Show resolved Hide resolved

Liuhaai and others added 2 commits August 27, 2021 16:30

Merge branch 'master' into issue#2567v2

386d866

add analyser endpoint

1806a91

millken reviewed Aug 30, 2021

View reviewed changes

ioctl/config/config.go Outdated Show resolved Hide resolved

Liuhaai and others added 2 commits August 30, 2021 17:45

remove debug code

ade00f8

Merge branch 'master' into issue#2567v2

47580be

raullenchai changed the title ~~fix issue#2567~~ Allow ioctl to show the list of actions for an account Sep 1, 2021

millken approved these changes Sep 1, 2021

View reviewed changes

CoderZhi approved these changes Sep 16, 2021

View reviewed changes

raullenchai and others added 2 commits September 16, 2021 10:57

Merge branch 'master' into issue#2567v2

6fa3b39

Merge branch 'master' into issue#2567v2

095937a

Liuhaai merged commit 44e0a68 into iotexproject:master Sep 17, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow ioctl to show the list of actions for an account #2750

Allow ioctl to show the list of actions for an account #2750

Liuhaai commented Jul 29, 2021 •

edited

Loading

todo bot commented Jul 29, 2021

codecov bot commented Jul 29, 2021 •

edited

Loading

dustinxie commented Aug 10, 2021

Liuhaai commented Aug 11, 2021

millken left a comment

Allow ioctl to show the list of actions for an account #2750

Allow ioctl to show the list of actions for an account #2750

Conversation

Liuhaai commented Jul 29, 2021 • edited Loading

todo bot commented Jul 29, 2021

remove struct definition after the release of anlytics v2

This comment was generated by todo based on a TODO comment in 4d67d90 in #2750. cc @Liuhaai.

codecov bot commented Jul 29, 2021 • edited Loading

Codecov Report

dustinxie commented Aug 10, 2021

Liuhaai commented Aug 11, 2021

millken left a comment

Choose a reason for hiding this comment

Liuhaai commented Jul 29, 2021 •

edited

Loading

This comment was generated by todo based on a `TODO` comment in `4d67d90` in #2750. cc @Liuhaai.

codecov bot commented Jul 29, 2021 •

edited

Loading