Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup coins package errors #378

Closed
3 tasks done
husio opened this issue Mar 6, 2019 · 1 comment · Fixed by #397
Closed
3 tasks done

Cleanup coins package errors #378

husio opened this issue Mar 6, 2019 · 1 comment · Fixed by #397
Assignees
@husio

Comments

@husio
Copy link
Contributor

husio commented Mar 6, 2019 •
edited
Loading

Cleanup coin package errors.
@husio husio added the cleanup label Mar 6, 2019
@ethanfrey
Copy link
Contributor

Yes, I agree, they can all be simplified to ErrOverflow.

@ethanfrey ethanfrey mentioned this issue Mar 6, 2019
Closed
@husio husio self-assigned this Mar 12, 2019
husio added a commit that referenced this issue Mar 12, 2019
@husio
cleanup coin package errors
600d74d 
- register `ErrCurrency` error that is return whenever an operation
  cannot be completed due to currency/ticker issues
- remove custom coin error declarations
- use existing errors instead of custom (now removed) instances

resolve #378
@husio husio mentioned this issue Mar 12, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@husio husio

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cleanup coin package errors iov-one/weave
2 participants
@husio @ethanfrey