Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup coin package errors #397

Merged
merged 1 commit into from
Mar 13, 2019
Merged

Conversation

husio
Copy link
Contributor

@husio husio commented Mar 12, 2019

  • register ErrCurrency error that is return whenever an operation
    cannot be completed due to currency/ticker issues
  • remove custom coin error declarations
  • use existing errors instead of custom (now removed) instances

resolve #378

- register `ErrCurrency` error that is return whenever an operation
  cannot be completed due to currency/ticker issues
- remove custom coin error declarations
- use existing errors instead of custom (now removed) instances

resolve #378
@husio husio requested a review from ethanfrey March 12, 2019 13:31
@husio husio requested a review from alpe as a code owner March 12, 2019 13:31
@husio husio removed the request for review from alpe March 12, 2019 13:31
@codecov-io

This comment has been minimized.

Copy link
Contributor

@ethanfrey ethanfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@husio husio merged commit 0e465ea into master Mar 13, 2019
@husio husio deleted the cleanup_coins_package_errors_issue_378 branch March 13, 2019 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cleanup coins package errors
3 participants