Deduct min fee on error #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
husio
reviewed
Feb 26, 2019
alpe
reviewed
Mar 4, 2019
x/cash/dynamicfee.go
Outdated
| } | ||
|
|
||
| // prepare is all shared setup between Check and Deliver, one more level above extractFee | ||
| func (d DynamicFeeDecorator) prepare(ctx weave.Context, store weave.KVStore, tx weave.Tx) (fee x.Coin, payer weave.Address, cache weave.KVCacheWrap, err error) { |
There was a problem hiding this comment.
pp: named return params should be avoided as a best practice. See https://github.com/golang/go/wiki/CodeReviewComments#named-result-parameters
ethanfrey
commented
Mar 4, 2019
|
I will rebase this with |
Caching configuration in a decorator makes it immutable and prevents from being updated during the runtime. If the performance is a concern, instead of caching in the decorator a store wrapper could be used that would keep an in memory representation of the whole gconf set and flush on any update.
ethanfrey
force-pushed
the
deduct-min-fee-on-error
branch
from
3ed05ad to
e73998f
Compare
|
Rebased everything on master to prepare to merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #348
Prepares #349
This embeds a checkpoint in a DynamicFeeDecorator, such that on success it will deduct the entire tx fee passed in the transaction, and on failure, only deducts the minimum fee.
Note this is designed for support of RequiredFee, but doesn't do that yet, just the variable deduction on tx failure. It would be good to test this is solid first in the face of possible attacks. (If the user pays less than minfee, it is rejected in CheckTx and nothing deducted, this is not really an attack).