Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable melodic checks #133

Merged
merged 2 commits into from
Apr 4, 2019
Merged

enable melodic checks #133

merged 2 commits into from
Apr 4, 2019

Conversation

jabbenseth
Copy link
Contributor

No description provided.

@jabbenseth
Copy link
Contributor Author

works towards ipa320/care-o-bot#52

@jabbenseth jabbenseth requested a review from fmessmer April 4, 2019 10:46
ipa-pfs
ipa-pfs previously approved these changes Apr 4, 2019
View reviewed changes
fmessmer
fmessmer requested changes Apr 4, 2019
View reviewed changes
Copy link
Member

@fmessmer fmessmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should I release this repo into melodic?
I'm about to do another tagging...and release session for some of the cob packages anyway
@ipa-jba

.travis.yml Outdated
- env: ROS_DISTRO=indigo UPSTREAM_WORKSPACE=debian
- env: ROS_DISTRO=kinetic UPSTREAM_WORKSPACE=debian
- env: ROS_DISTRO=melodic UPSTREAM_WORKSPACE=file
- env: ROS_DISTRO=melodic UPSTREAM_WORKSPACE=debian
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as all six travis jobs succeed, I would remove the allow_failures block completely

@jabbenseth
Copy link
Contributor Author

a release for melodic would be great. I will remove the allow failure tag. Kept it since it is part of the accepted template in cob_common

@fmessmer
Copy link
Member

fmessmer commented Apr 4, 2019 •
edited
Loading

@ipa-jba
as cob_common is already released into melodic (http://repositories.ros.org/status_page/ros_melodic_default.html?q=cob), we might want to remove the allow_failures there, too - could you provide a PR there, too?

the allow_failures were for testing whether the tests would pass for melodic 😉

@fmessmer fmessmer merged commit 985a262 into ipa320:indigo_dev Apr 4, 2019
@jabbenseth
Copy link
Contributor Author

https://github.com/ipa320/cob_common/pull/267 there you go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmessmer fmessmer fmessmer approved these changes

@ipa-pfs ipa-pfs ipa-pfs left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jabbenseth @fmessmer @ipa-pfs