Noetic Migration and Bugfixes for OpenCV AdaBoosting #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ipa-foj
commented
Dec 17, 2021
ipa-foj
commented
- Noetic migration of the code to run with OpenCV 4.2
- Addresses issue room_segmentation_algorithm:4 can not run #12 and The code "room_boost_->predict" crashes. #14
Noetic dev
ipa-rmb
previously approved these changes
Dec 17, 2021
| @@ -3,7 +3,7 @@ | |||
|
|
|||
|
|
|||
| <!-- --> | |||
| <node ns="room_segmentation" pkg="ipa_room_segmentation" type="room_segmentation_server" name="room_segmentation_server" output="screen" respawn="true" respawn_delay="2"> | |||
| <node ns="room_segmentation" pkg="ipa_room_segmentation" type="room_segmentation_server" name="room_segmentation_server" output="screen" respawn="false" respawn_delay="2"> | |||
There was a problem hiding this comment.
Why false? Wasn't this our fallback for sporadic crashes of the component? Or does it never crash anymore?
There was a problem hiding this comment.
True, overlooked that during the push, thanks for notifying. Reverted it to respawn=true in the new commit.
ipa-rmb
approved these changes
Jan 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.