Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New feature #2

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

New feature #2

wants to merge 9 commits into from

Conversation

VladimirIvan
Copy link
Collaborator

  • Added new print out

@ferrolho
Copy link
Collaborator

👏

ferrolho
ferrolho requested changes Oct 13, 2017
View reviewed changes
Copy link
Collaborator

@ferrolho ferrolho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

summary

src/useful_script.py Outdated

print('This is a useful script')

print('I like banana milkshakes')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like this...

yimingyanged
yimingyanged reviewed Oct 13, 2017
View reviewed changes
Copy link

@yimingyanged yimingyanged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure it is really useful.

src/useful_script.py
while(True):
print('I sure am printing now...')

print('This was very useful!')
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it?

ferrolho
ferrolho approved these changes Oct 13, 2017
View reviewed changes
src/useful_script.py Outdated
@@ -2,7 +2,7 @@

print('This is a useful script')

print('I like banana milkshakes')
print('I like strawberry milkshakes')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better 👍 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yimingyanged yimingyanged yimingyanged left review comments

@ferrolho ferrolho ferrolho approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@VladimirIvan @ferrolho @yimingyanged