This repository was archived by the owner on Mar 10, 2020. It is now read-only.
fix: do not rely on discovery for ping tests #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes #310 License: MIT Signed-off-by: Alan Shaw <alan@tableflip.io>
ghost
assigned
alanshaw
commented
Jun 26, 2018
| spawnNodes(n, factory, (err, nodes) => { | ||
| if (err) return callback(err) | ||
| map(nodes, identify, callback) | ||
| }) |
There was a problem hiding this comment.
Apologies the change in this file should have been proposed a separate PR - this simply ensures the ID calls are done in parallel which will speed up the tests a little.
|
LGTM! |
alanshaw
added a commit
that referenced
this pull request
Jun 26, 2018
As per original PR #311 License: MIT Signed-off-by: Alan Shaw <alan@tableflip.io>
alanshaw
added a commit
that referenced
this pull request
Jun 26, 2018
As per original PR #311 License: MIT Signed-off-by: Alan Shaw <alan@tableflip.io>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ping tests do not need to test that peers can discover each other. This PR removes the
waitUntilConnectedutility and explicitly connects the nodes that are used in the tests.fixes #310