Skip to content
This repository has been archived by the owner on Mar 10, 2020. It is now read-only.

ping tests on Windows fail a lot #725

Closed
vmx opened this issue Mar 29, 2018 · 4 comments
Closed

ping tests on Windows fail a lot #725

vmx opened this issue Mar 29, 2018 · 4 comments
Assignees
@alanshaw
Labels
bug difficulty:moderate P1 - High

Comments

@vmx
Copy link
Contributor

vmx commented Mar 29, 2018

Probably due to #718 the ping tests on Windows got flaky:
@victorb
Copy link
Contributor

victorb commented Mar 29, 2018 •
edited
Loading

Quick fix would be to add logic in the test to be able to flag a test as "flaky" and if it has that tag, retry it X times before actually failing. Since now we don't really know if it's failing or just being flaky, with X being higher, we can more certain it's an actual error. + we probably need this for other flaky tests as well.

@alanshaw alanshaw mentioned this issue May 16, 2018
Merged
@alanshaw
Copy link
Contributor

Windows tests have consistently failed since 427322d when we switched to go-ipfs-dep@0.4.14.

@alanshaw alanshaw self-assigned this Jun 18, 2018
@alanshaw alanshaw mentioned this issue Jun 22, 2018
Closed
@alanshaw
Copy link
Contributor

Looks like there is a peer discovery regression on Windows. I've opened ipfs/kubo#5146

@alanshaw
Copy link
Contributor

This was resolved by ipfs-inactive/interface-js-ipfs-core#311

@ghost ghost removed the ready label Jul 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alanshaw alanshaw

Labels
bug difficulty:moderate P1 - High
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@vmx @alanshaw @victorb @daviddias