This repository has been archived by the owner on Mar 10, 2020. It is now read-only.
go-ipfs 0.4.14 compat #718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
Update: made sure it passes with 0.4.14-rc3-d475318ff, no issues currently |
victorb
changed the title
|
Update: tried with latest go-ipfs master ( |
|
@diasdavid could you do the release dance to get go-ipfs-dep and js-ipfsd-ctl released with new go-ipfs version? 0.4.14 has been released now |
Since 0.4.14, go-ipfs now returns an empty array rather than null. This should be considered a breaking change for consumers of this library.
daviddias
force-pushed
the
go-ipfs-0.4.14-compat
branch
from
cf8583e
to
aac6f33
Compare
…count and n are used at the same time
|
But I'll wait for CI ;) |
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created to support work on ipfs/kubo#4818 (comment)
Since 0.4.14, go-ipfs now returns an empty array rather than null.
This should be considered a breaking change for consumers of this
library.