This repository has been archived by the owner on Oct 16, 2020. It is now read-only.
fix: detect ipfs-companion in Chromium-based browsers #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lidel
changed the title
9 tasks
Chrome does not expose `browser` namespace, instead it uses `chrome`, which does not support promises. Firefox supports both so we switch to Chrome notation.
lidel
force-pushed
the
fix/detect-companion-in-chromium
branch
from
f193227
to
29cbfac
Compare
|
@olizilla ok to merge or do we want to also remove window.ipfs as noted in ipfs/ipfs-webui#787 (comment) ? |
olizilla
approved these changes
Oct 1, 2018
I do, I'll release this and add you to the npm list. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Chrome does not expose
browsernamespace, instead it useschrome(fun fact: which does not support promises 🙃)Firefox supports both so we switch to Chrome notation as the lowest common denominator supported by all vendors.
(After this is merged & releases we need to bump dep version used by WebUI)